cfjedimaster / brackets-jshint

Adds JSHint support to Brackets
MIT License
130 stars 41 forks source link

Adding support for global preferences #79

Closed Lichtjaeger closed 9 years ago

Lichtjaeger commented 9 years ago

I have added user global preferences for linting options.

cfjedimaster commented 9 years ago

Nice!

busykai commented 9 years ago

@cfjedimaster, could you please, in the future, ask contributors to not change line endings in the files?

cfjedimaster commented 9 years ago

Does it matter? (Serious question - didn't seem to matter to me and my editor.)

busykai commented 9 years ago

It does matter. It matters to git blame. When you git bisect, you may end up with a commit that changes the entire file. Then go figure what introduced the issue (if anything). You'll have to do extra just because someone wasn't careful enough.

Most of the editors would handle line endings for you, but it's not about the editor. It's about understanding what the change was (and being respectful to others).

Lichtjaeger commented 9 years ago

Sorry. git-tools for brackets automaticaly cleans whitespaces and lineendings on commit.