search

cfjedimaster / brackets-jshint

Adds JSHint support to Brackets
MIT License
130 stars 41 forks source link

Jshint 2.9.1 #85

Open hacker112 opened 8 years ago

hacker112 commented 8 years ago

It would be nice to have Jshint 2.9.1. Some things seem to have been fixed so that brackets-jshint gives different result than the new jshint.

I tried to only replace the jshint.js in the extension but it did not work. Then I saw something about monkey-patch of jshint in a previous commit. Would be nice to help with a pull request, but don't know where to start and why it is not just to replace the jshint.js file.

cfjedimaster commented 8 years ago

Next time I do another update I'll update the library. Unless someone else does a PR first.

On Tue, Feb 2, 2016 at 9:46 AM, hacker112 notifications@github.com wrote:

It would be nice to have Jshint 291 Some things seem to have been fixed so that brackets-jshint gives different result than the new jshint

I tried to only replace the jshintjs in the extension but it did not work Then I saw something about monkey-patch of jshint in a previous commit Would be nice to help with pull request, but don't know where to start and why it is not just to replace the jshintjs file

— Reply to this email directly or view it on GitHub https://github.com/cfjedimaster/brackets-jshint/issues/85.

Raymond Camden, Developer Advocate for MobileFirst at IBM

Email : raymondcamden@gmail.com Blog : www.raymondcamden.com Twitter: raymondcamden

hacker112 commented 8 years ago

There seems to be a huge difference between the release 2.7.0 (repo/dist/jshint.js) https://github.com/jshint/jshint/releases/tag/2.7.0 and the 2.7.0 in used here. Why is it so? Is it take from somewhere else?

cfjedimaster commented 8 years ago

No idea. I normally grab from jshint's repo. Maybe I screwed up. Would gladly take a PR that would fix it and get it to 2.9.1 or latest. :)

On Fri, Mar 4, 2016 at 2:10 AM, hacker112 notifications@github.com wrote:

There seems to be a huge difference between the release 2.7.0 (repo/dist/jshint.js) https://github.com/jshint/jshint/releases/tag/2.7.0 and the 2.7.0 in used here. Why is it so? Is it take from somewhere else?

— Reply to this email directly or view it on GitHub https://github.com/cfjedimaster/brackets-jshint/issues/85#issuecomment-192175300 .

Raymond Camden, Developer Advocate for MobileFirst at IBM

Email : raymondcamden@gmail.com Blog : www.raymondcamden.com Twitter: raymondcamden

hacker112 commented 8 years ago

After finding that monkey patch that was needed it works :) First I compared with 2.7 instead of 2.8 that was the last updated version. But when I compared the original to the monkey patched 2.8 I found the monkey patch and was able to add the same patch to 2.9.1.