cflint / CFLint

Static code analysis for CFML (a linter)
BSD 3-Clause "New" or "Revised" License
174 stars 84 forks source link

GPG error on mvn clean install #23

Closed btudor closed 9 years ago

btudor commented 10 years ago

Keep getting a MojoExecutionException error due to Maven not being able to grab dependency: org.apache.maven.plugins:maven-gpg-plugin

ryaneberly commented 10 years ago

Sorry about that. We have that plugin for signing the jar for maven. We're still figuring out how to make local builds not require that.

For now, if you comment the maven-gpg-plugin plugin (lines 213-226) in the pom.xml. It should complete the clean install successfully.

ryaneberly commented 10 years ago

I think we need to do something like this: http://stackoverflow.com/questions/14825039/suppressing-gpg-signing-for-maven-based-continous-integration-builds-travis-ci

btudor commented 10 years ago

Ryan,

Many thanks for your reply – I got round the problem by installing GPG4Win, putting it on the path and creating an initial Cert. Your excellent CFLint went ahead using that fine.

(but it would be nice if we could optionally skip the pgp part altogether perhaps).

So after that I got CFLint working by running: java –jar apart from log4j which I assume I will also have to install and configure correctly?

I am curious – is there a way to set a default ouput file instead of outputting to console by default when output is set in the UI to Text?

I am happy to update Docs for you to help anyone else when trying out CFLint for first time.

Thanks for a great tool.

Regards,

Bill

From: ryaneberly [mailto:notifications@github.com] Sent: 11 November 2014 12:27 To: cflint/CFLint Cc: Bill Tudor Subject: Re: [CFLint] GPG error on mvn clean install (#23)

I think we need to do something like this: http://stackoverflow.com/questions/14825039/suppressing-gpg-signing-for-maven-based-continous-integration-builds-travis-ci

— Reply to this email directly or view it on GitHub https://github.com/cflint/CFLint/issues/23#issuecomment-62539978 .Description: Image removed by sender.

ryaneberly commented 10 years ago

I am curious – is there a way to set a default ouput file instead of outputting to console by default when output is set in the UI to Text? I am happy to update Docs for you to help anyone else when trying out CFLint for first time.

if you are using the cflint-ui.bat (or unix cflint-ui), cflint-ui.bat -textfile example: cflint-ui.bat -textfile c:\temp\out.txt

It will open automatically (at least in windows) when it is finished.

By all means start a wiki page, (https://github.com/cflint/CFLint/wiki) You input is welcome!

jjames967 commented 10 years ago

I've uploaded a new pom with all the jar/javadoc stuff commented out for now. Hopefully there won't be further issues with it.

I also started a wiki page a while ago. I just haven't been actively updating it. The more people contributing, the better!

btudor commented 10 years ago

Ryan/James,

I have updated Wiki (a small contribution, but it’s a start). Thanks for your help.

Bill Tudor

From: ryaneberly [mailto:notifications@github.com] Sent: 12 November 2014 03:26 To: cflint/CFLint Cc: Bill Tudor Subject: Re: [CFLint] GPG error on mvn clean install (#23)

I am curious – is there a way to set a default ouput file instead of outputting to console by default when output is set in the UI to Text? I am happy to update Docs for you to help anyone else when trying out CFLint for first time.

if you are using the cflint-ui.bat (or unix cflint-ui), cflint-ui.bat -textfile example: cflint-ui.bat -textfile c:\temp\out.txt

It will open automatically (at least in windows) when it is finished.

By all means start a wiki page, (https://github.com/cflint/CFLint/wiki) You input is welcome!

— Reply to this email directly or view it on GitHub https://github.com/cflint/CFLint/issues/23#issuecomment-62664735 .Description: Image removed by sender.

ryaneberly commented 10 years ago

Bill, I invited you to the contributor group on CFLint, that will allow you to commit to the git repo.

If you are interested it contributing a bit further, take a look at Issue

25

On Thu, Nov 13, 2014 at 6:03 AM, Bill Tudor notifications@github.com wrote:

Ryan/James,

I have updated Wiki (a small contribution, but it’s a start). Thanks for your help.

Bill Tudor

From: ryaneberly [mailto:notifications@github.com] Sent: 12 November 2014 03:26 To: cflint/CFLint Cc: Bill Tudor Subject: Re: [CFLint] GPG error on mvn clean install (#23)

I am curious – is there a way to set a default ouput file instead of outputting to console by default when output is set in the UI to Text? I am happy to update Docs for you to help anyone else when trying out CFLint for first time.

if you are using the cflint-ui.bat (or unix cflint-ui), cflint-ui.bat -textfile example: cflint-ui.bat -textfile c:\temp\out.txt

It will open automatically (at least in windows) when it is finished.

By all means start a wiki page, (https://github.com/cflint/CFLint/wiki) You input is welcome!

— Reply to this email directly or view it on GitHub < https://github.com/cflint/CFLint/issues/23#issuecomment-62664735> .Description: Image removed by sender.

— Reply to this email directly or view it on GitHub https://github.com/cflint/CFLint/issues/23#issuecomment-62874911.

jjames967 commented 9 years ago

I've looked into this... it's set up as:

        <plugin>
            <groupId>org.apache.maven.plugins</groupId>
            <artifactId>maven-gpg-plugin</artifactId>
            <version>1.5</version>
            <executions>
                <execution>
                    <id>sign-artifacts</id>
                    <phase>verify</phase>
                    <goals>
                        <goal>sign</goal>
                    </goals>
                </execution>
            </executions>
        </plugin>

When I execute "mvn clean install" it doesn't generate signed files. It only runs when I do "mvn verify". So I'm wondering why it's asking people who don't have gpg installed for it to be installed.

jjames967 commented 9 years ago

My plan is to redo how the build is deployed. Hopefully it will remove any further issues.