search

cflint / CFLint

Static code analysis for CFML (a linter)
BSD 3-Clause "New" or "Revised" License
174 stars 84 forks source link

PARSE_ERROR when function argument list has trailing comma #365

Closed mpaluchowski closed 6 years ago

mpaluchowski commented 7 years ago

A function declaration, where the argument list has a trailing comma, such as:

public function foo(
    required any bar, 
    required any baz,
) {}

will trigger a PARSE_ERROR. The code works fine (in Railo 4.2 at least).

KamasamaK commented 7 years ago

I don't believe this works in ACF. Must just be Railo/Lucee.

TheRealAgentK commented 7 years ago

If it doesn't work in ACF, then we should currently not go out of our way to support it. As much as I'd like to support Lucee properly at some point, let's focus on getting 1.2 and 1.3 out and then have a proper think about refactoring certain parts for 2.0 - and supporting Lucee properly could well be one of those things.

TheRealAgentK commented 7 years ago

Needs to be looked at in cfparser.

ryaneberly commented 6 years ago

this is resolved. will be included in v 1.3.0