cflint / CFLint

Static code analysis for CFML (a linter)
BSD 3-Clause "New" or "Revised" License
174 stars 84 forks source link

maven install should install the binaries in a usable way #51

Closed displague closed 9 years ago

displague commented 9 years ago

Following mvn clean install I currently symlink ~/src/CFLint/target/appassembler/bin/cflint to somewhere in my path (~/.local/bin). I also have to make the binary executable chmod a+x ~/src/CFLint/target/appassembler/bin/cflint. These steps (setting permissions, and installing the appassembler artifacts) should be part of the install.

ryaneberly commented 9 years ago

It looks like appassembler-maven-plugin resolved this. http://jira.codehaus.org/browse/MAPPASM-54

Try using version 1.10 of the appassembler-maven-plugin in the cflint/pom.xml

displague commented 9 years ago

The execute bit is set with 1.10 but that doesn't address how one gets the appassembler artifacts into usable locations.

displague commented 9 years ago

Does it have something to do with: http://mojo.codehaus.org/appassembler/appassembler-maven-plugin/create-repository-mojo.html#assembleDirectory is there a way to mvn clean install --assembleDirectory=~/.local (or /usr/local/ or /opt/ as others may choose) ?

ryaneberly commented 9 years ago

you can do that: mvn clean install -DassembleDirectory=~/.local

it will create files in bin/ lib/ and etc/ folders.

I'm not necessarily recommending this. We may need to leave that last step up the user.

displague commented 9 years ago

Thanks! mvn clean install -D assembleDirectory=~/.local worked (had to remove the dash after -D).

I think it's worth noting in the build instructions (perhaps with a more common directory like /usr/local/).