getting false positives on escaped pounds

[esanfordwss]

https://github.com/cflint/CFLint/blob/ea8ffcdf83a73b5238ed02276f2463ebde44679c/src/main/java/com/cflint/plugins/core/QueryParamChecker.java#L26

Should be [^#]#[^#] to instead of .#[^#]

[ryaneberly]

@esanfordwss, Thanks!

[KamasamaK]

There should be a test added that produces the false positive with the old pattern. Also, there should be one that handles more complex combinations like

<cfquery name="query" datasource="dsn">
    SELECT  *
    FROM    Table
    WHERE   column = '###foo###'
</cfquery>

[ryaneberly]

@KamasamaK. Makes sense, reopening.,

[KamasamaK]

I just tested with the following in 1.4.1, and still get a false positive

<cfquery name="testQuery" datasource="dsn">
    SELECT  *
    FROM    Table
    WHERE   column = '##Hello##'
</cfquery>

[ryaneberly]

fixed in dev.