cflint / CFLint

Static code analysis for CFML (a linter)
BSD 3-Clause "New" or "Revised" License
174 stars 83 forks source link

Migrate from Travis CI to GitHub Actions #674

Open KamasamaK opened 4 years ago

KamasamaK commented 4 years ago

I will start by saying I'm not really familiar with Travis CI. I noticed the builds were failing when I submitted a PR and saw the results of Build 1390. It seemed clear that updating Gradle in Docker should address the issue, so I did that in another PR and it appeared to work based on Build 1393. However, now that the PR is merged the builds appear to progress successfully, but never terminate. See Build 1394 for the most recent example.

KamasamaK commented 4 years ago

cc @steinbrueckri

steinbrueckri commented 4 years ago

@KamasamaK Maybee, I can take a look later today. But from my first look its a Gradle issue, I think.

FAILURE: Build failed with an exception.
* Where:
Build file '/home/gradle/src/build.gradle' line: 23
* What went wrong:
An exception occurred applying plugin request [id: 'com.github.johnrengelman.shadow', version: '5.1.0']
> Failed to apply plugin [class 'com.github.jengelman.gradle.plugins.shadow.ShadowBasePlugin']
   > This version of Shadow supports Gradle 5.0+ only. Please upgrade.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

@KamasamaK Can you assign me the task?

KamasamaK commented 4 years ago

@steinbrueckri Assigned. That's the issue I tried to resolve by updating Gradle, which seemed to work for Build 1393, but none after that.

steinbrueckri commented 4 years ago

@KamasamaK just one question in the meantime, Github Action is released. Should I take a look at how we can migrate to Github Actions? Github Actions is mutch better integrated then Travis-CI.

KamasamaK commented 4 years ago

@steinbrueckri Sure. We're not married to Travis CI.

steinbrueckri commented 4 years ago

@KamasamaK @ryaneberly @TheRealAgentK Has someone admin for the repo? I ask because we need to add some secrets to the Repo settings. See the Creating and storing encrypted secrets for more informations.

BTW: Has anybody access to the cflint dockerhub account? If not we can try to claim it

If needed, I'm reachable on Gitter for 1-to-1 communication.

Cheers Richard 🍻

ryaneberly commented 4 years ago

@KamasamaK promoted to admin :p. I'll look at this when I have time --- if you beat me to it go for it.

ryaneberly commented 4 years ago

@steinbrueckri . I put a request in for the dockerhub account

steinbrueckri commented 4 years ago

@ryaneberly Have you stored the Username and the Password? What I need is one Secret _DOCKERHUBTOKEN that contains an API TOKEN, you can create one here https://hub.docker.com/settings/security.

ryaneberly commented 4 years ago

no action on my request to get the cflint dockerhub account. any alt names to suggest?

steinbrueckri commented 4 years ago

@ryaneberly cf-lint?