search

cfmrp / mtool

Software to Manipulate Different Flavors of Semantic Graphs
http://mrp.nlpl.eu
GNU Lesser General Public License v3.0
51 stars 24 forks source link

Another fix for evaluation of empty graphs. #54

Closed foxik closed 5 years ago

foxik commented 5 years ago

The recent changes in mces_limit again broke evaluation of empty graphs.

This time the fix sets best_cv and best_ce back to None, and explicitly uses best_cv or pairs or {} as the argument to g.score. Another possibility would be to fix g.score not to fail when pairs=[], but I am too lazy for that.

Also note that all four combinations ({empty,nonempty} vs {empty,nonempty} graphs) work, it is not necessary to check nodes of the system graph for emptiness.

oepen commented 5 years ago

thanks, again, milan! we have now added various empty graphs to our collection of test cases, and have finally enabled continuous integration :-).