search

cfn-modules / rds-aurora-serverless

RDS Aurora Serverless cluster with secure firewall configuration, encryption, multi AZ, auto scaling, backup enabled, and alerting
Apache License 2.0
8 stars 5 forks source link

Removing utf-8 character from comment #10

Closed ptmclean closed 4 years ago

ptmclean commented 5 years ago

Hi, With the latest aws cli running on an ubuntu server I was not able to run aws cloudformation package with these characters in the template. I'm assuming they were intended to be $ signs anyway so hopefully this is a simple one.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

michaelwittig commented 5 years ago

the reason why i onc replaced $ with § ist that cfn-lint reports that we forget a !Sub if we use ${} in a string :) Can you paste the error message that you receive here? and the AWS CLI version (aws --version?

ptmclean commented 5 years ago

Oops, I should have linted before raising. Sorry about that. Here is the output from aws --version aws-cli/1.16.166 Python/3.5.3 Linux/4.9.77-31.58.amzn1.x86_64 botocore/1.12.156

And the error is...

Unable to upload artifact ./node_modules/@cfn-modules/rds-aurora-serverless/module.yml referenced by TemplateURL parameter of AuroraServerlessCluster resource.
'ascii' codec can't decode byte 0xc2 in position 2789: ordinal not in range(128)

I guess it is more related to the python version than anything else. Assuming it is a problem how about an "S" for the "$" in the comment? or even just a space between the "$" and the "{"/

michaelwittig commented 5 years ago

can you run the aws command with --debug and ensure that there are no special characters in your command? (you can paste the command here https://jhy.io/tools/convert-word-to-plain-text to clean it up)