search

cfnz / muirwik

Muirwik - a Material UI React wrapper written in Kotlin
Mozilla Public License 2.0
132 stars 25 forks source link

Add Alert Wrapper #38

Closed marvinbuff closed 3 years ago

marvinbuff commented 3 years ago

Hi, thanks for the awesome library. I know everything is still WIP, so I thought I would make some contributions while using it.

I currently need to use the Alert component which does not yet have any wrapper. So I just created one.

Let me know if you have any feedback or requested changes. Especially in regards to the dependency to material-ui/lab. Not sure if you don't want to depend on the experimental library or if you just didn't get to create wrappers for it yet.

cfnz commented 3 years ago

Hi there, thanks for that.

I mainly have not included the lab stuff more for the experimental nature of it, but I don't mind adding it if it is useful. Will be interesting to see how the Kotlin DCE deals with it.

I will add a couple of comments in the code review too :-)

marvinbuff commented 3 years ago

Implemented the changes as requested. I also added some comments which hopefully help to understand the difference between the builders.

As a side note: I will use this library extensively for some time. Are you interested in more pull requests? For instance I would have some changes to the table to make it more generic, and I would like to have some utility changes to work on it. Do you generally welcome such changes?

cfnz commented 3 years ago

Yes, happy to receive pull requests, I might be a bit slow turning them around, but I do hope to do so.

I added the AlertTitle to your pull request and made a few tweaks (hope you don't mind :-)).

But yes, the more people improving the better :-).