default Material-UI control Margin on FormControls

cfnz / muirwik

Muirwik - a Material UI React wrapper written in Kotlin

Mozilla Public License 2.0

132 stars 25 forks source link

default Material-UI control Margin on FormControls #54

Closed sirakuzovsky closed 2 years ago

sirakuzovsky commented 3 years ago

MFormControlMargin.none is default by Material-UI, not MFormControlMargin.normal see official docs

cfnz commented 3 years ago

In mFormControl it defaulting to none. Are you referring to its use in mTextField?

sirakuzovsky commented 3 years ago

Yes, on mTextField mGridItem(xs = MGridSize.cells12, sm = MGridSize.cells6) { mTextField( required = true, /value = city,/ name = "city", label = "City", fullWidth = true, autoComplete = "shipping address-level2", margin = MFormControlMargin.none ) }

cfnz commented 3 years ago

That is a nuisance... you are right, it should have been none (or null)... If I change it now it may break existing layouts (it made a bit of a mess of the test app), so I might change it in a bigger breaking change version... maybe even with the rollout of version 5. So will leave this open till then...

cfnz commented 2 years ago

Version 5 has been merged to master and does not have this issue.