search

cfnz / muirwik

Muirwik - a Material UI React wrapper written in Kotlin
Mozilla Public License 2.0
132 stars 25 forks source link

Add toggle button component #78

Closed marvinbuff closed 3 years ago

marvinbuff commented 3 years ago

I added the toggle button component with a test example.

My last PR for the hacktorberfest :)

cfnz commented 3 years ago

Thanks for that, I will have a look... I actually already implemented Toggle Button as part of the version 5 branch where it was moved out of the lab, but will have a look how this integrates.

I have moved the Skeleton over to version 5 as it is also "out of the lab", but I have not moved over the pagination or treeview components yet.

If you want, you can have a look at version 5 and see how much it breaks things :smiley: (though I think it is worth while).

marvinbuff commented 3 years ago

Ah I see, yeah your changes pretty much cover everything. Maybe I get the time to move the pagination and treeview component over.

cfnz commented 3 years ago

Yes, it does change a fair bit... almost everything indeed... Will be great if you can move over pagination and treeview... will also be interesting to hear how the change "feels". Maybe they should be in a lab sub-directory.