cfoge / VHDL_parse

A collection of Python scripts to make working with VHDL easier
MIT License
2 stars 3 forks source link

token_test.py - missing initialization for component_ranges #16

Open ajeethakv opened 3 months ago

ajeethakv commented 3 months ago

I get an error while trying testbench.py:

  File "testbench.py", line 6, in <module>
    decoded = parse_vhdl(files_to_tb, True)
  File "/home/ajeetha/tools/git_VHLD_Parse/ak_dev/vhdl_tokeniser/token_test.py", line 910, in parse_vhdl
    for range in component_ranges:
UnboundLocalError: local variable 'component_ranges' referenced before assignment

My fix/attempt is simple - initialize it as:

    component_ranges = ''

Do you need a PR?

cfoge commented 3 months ago

oh sure, that would be great. I need to make some proper unit tests for the different python scripts so I don't end up breaking them when i make other improvements.

Thanks.

I also need to go through and document some of the scripts in the tokeniser folder. cl_tree_graph_selective is super useful and so is trace_sign_selective (doesn't always work for complex projects)

On Fri, 17 May 2024 at 17:09, ajeethakv @.***> wrote:

I get an error while trying testbench.py:

File "testbench.py", line 6, in decoded = parse_vhdl(files_to_tb, True) File "/home/ajeetha/tools/git_VHLD_Parse/ak_dev/vhdl_tokeniser/token_test.py", line 910, in parse_vhdl for range in component_ranges: UnboundLocalError: local variable 'component_ranges' referenced before assignment

My fix/attempt is simple - initialize it as:

component_ranges = ''

Do you need a PR?

— Reply to this email directly, view it on GitHub https://github.com/cfoge/VHLD_parse/issues/16, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHGSUVMCXCUFEZIZVP5EDRTZCWUMLAVCNFSM6AAAAABH3SMZM6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGMYDCOJYG43DEMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

--


Robert D Jordan PH: 0423376150 @.***

cfoge commented 3 months ago

I just did some updates and improvements, so you might want to get the latest version. it has improvements to the test-bench generator