cfortuner / promptable

Build LLM apps in Typescript/Javascript. 🧑‍💻 🧑‍💻 🧑‍💻 🚀 🚀 🚀
https://docs-promptable.vercel.app
MIT License
1.77k stars 120 forks source link

OpenAI provider should use instance's `completionsConfig` and `embeddingsConfig` #27

Closed mjirv closed 1 year ago

mjirv commented 1 year ago

Problem

The OpenAI provider has fields for completionsConfig and embeddingsConfig. However, these are unused. The generate() and embed() functions default to DEFAULT_OPENAI_EMBEDDINGS_CONFIG and DEFAULT_COMPLETION_OPTIONS instead.

While these can be used by calling e.g. openAI.generate(prompt, openAI.completionsConfig) it's a better dev experience to simply default to the relevant config.

Solution

I'll submit a PR.