strogonoff
commented
1 week ago Same issue.
- Turns out, 99% of the time I’m on 48 kHz (just stock Mac DAC to be honest, occasionally BT headphones).
- Recently been working on a patch with heavy use of a couple of Player instances. They were sampling a couple of WAVs recorded from another VCV patch of mine—so, also 48 kHz.
- Today randomly decided to connect a Bluetooth speaker that works at 44.1, and everything sounds out of tune (I thought I messed up the patch).
I’d say resampling shouldn’t be done by default, but perhaps it could be an option. If there’s a module that can resample audio, that’d work just fine, but I couldn’t find one. I obviously can resample recorded WAVs themselves, but I’d rather not have to load a new sample in this situation…
Player’s great overall, somehow other samplers tend to be either overly complicated or not functional enough.
I noticed this while playing a 44.1 kHz recording of my voice through the Player module. My voice sounded artificially high-pitched. Then I noticed in the menu [VCV Rack / Engine / Sample rate] that my rendering sample rate was set to 48 kHz. When I changed that sample rate to 44.1 kHz to match the WAV file's sampling rate, my voice sounds correct.
It makes sense that Player is reading samples from the file and sending them to its LEFT/RIGHT output ports. When the sample rate doesn't match, the audio sounds wrong. It would be nice to resample to the target sampling rate.
I know this is not a trivial request, but as a fellow developer, I'm willing to jump in and help with the resampling changes, should you choose to do this. There are some dsp helper functions in the VCV Rack SDK that should make this mostly painless.
I will be happy to submit a PR if you are open to it. Just let me know.