search

cfpb / api

Documentation to support upcoming data platform API and data sets
http://cfpb.github.io/api/hmda/
31 stars 73 forks source link

Mosaic update #61

Closed niqjohnson closed 7 years ago

niqjohnson commented 7 years ago

DO NOT MERGE YET

Update the CCDB API documentation for release 13. DO NOT MERGE until release 13 is complete.

Additions

Changes

Testing

  1. Pull down niqjohnson/mosaic-update
  2. Start the site with bundle exec jekyll serve --watch --baseurl ''
  3. Confirm all four pages at http://127.0.0.1:4000/ccdb/ match the screenshots below
  4. Confirm the "Learn more about complaint form changes to products and sub-products" link opens a nine-page PDF titled "CFPB Summary of product and sub-product changes"
  5. Confirm the "View full list of complaint form products, sub-products, issues and sub-issues" link opens a 35-page PDF titled "Consumer Complaint Form Product and Issue Options"

Screenshots

What is this data Release notes API documentation Field reference
what-is-this-data release-notes api-doc field-reference

Notes

Todos

anselmbradford commented 7 years ago

Read through the text and didn't see any issues.

niqjohnson commented 7 years ago

The missing serial comma is in there now. The other suggested edit is under review. If everyone signs off on that before the scheduled launch, I'll make that fix. Otherwise, we can add it as a follow-up fix.

niqjohnson commented 7 years ago

The other text change was approved, too (with the exception of "some" needing to stay in), and is fixed in https://github.com/cfpb/api/pull/61/commits/9d0466c2016b5139e115ede40186c910b52e7ff3. @anselmbradford, want to take one more look at this?