search

cfpb / capital-framework

The Consumer Financial Protection Bureau's user interface framework
https://cfpb.github.io/capital-framework/
Creative Commons Zero v1.0 Universal
54 stars 29 forks source link

Do content_line and rule break atom overlap? #423

Closed anselmbradford closed 7 years ago

anselmbradford commented 7 years ago

Cfgov-refresh has a rule break atom (horizontal rule line) here. Capital Framework has a content line here.

Can these be merged? Should they both exist?

jimmynotjim commented 7 years ago

I never even knew this or content_bar existed. They don't seem like they belong in cf-layout (though neither do heros or featured content) so I'd think we should keep the a-rule atom and maybe add a modifier that makes it 10px to replace content_bar

Scotchester commented 7 years ago

content_bar should not be considered an atom (or modified atom). It's really just a border, that we had to make its own HTML element because reasons.

jimmynotjim commented 7 years ago

@Scotchester do you have examples of where it and content-bar are being used? It'd be nice to know what the reasons are and justify them.

Scotchester commented 7 years ago

Sorry, I should have looked before commenting. Looks like content_bar is no longer needed. It was required when the design specs had the green border under the header moving under the hero, if a hero was present.

content_line is used to divide the top content are from the bottom content area on a page with a breakout sidebar: http://www.consumerfinance.gov/policy-compliance/rulemaking/

jimmynotjim commented 7 years ago

@anselmbradford seems we have our answer, only use content_line if you're breaking up the content elem.