Deprecate accordions - Githubissues

cfpb / capital-framework

The Consumer Financial Protection Bureau's user interface framework

https://cfpb.github.io/capital-framework/

Creative Commons Zero v1.0 Universal

54 stars 29 forks source link

Deprecate accordions #665

Open anselmbradford opened 7 years ago

anselmbradford commented 7 years ago

Based on recent discussion, single expandables should be deprecated and all expandables should appear inside an expandable-group, even if it's one item. o-expandable likely would be deprecated, and o-expandable-group_item or similar added.

Current behavior

Expandables and expandable groups are separate organisms, but are delivered inter-twined.

Expected behavior

Since expandables and expandabled groups are delivered together, they should be fully merged as one organism.

anselmbradford commented 7 years ago

Proposals going forward:

Expandable.js is turned into a group and no expandable ever appears outside of a group, even if there is only one. Vote 🎉 :
Expandable.js is broken into ExpandableGroup.js and Expandable.js. ExpandableGroup.js handles accordion behavior. Expandable groups and single expandables may both exist. Vote ❤️
Expandable.js has accordion behavior removed and expandable groups disappear. Vote 👍

@cfpb/cfgov-frontends Please vote on one (or if you have a radical 🍣 throw that into the mix and screw up this whole process. Add your vote as an emoji reaction to this comment.

anselmbradford commented 7 years ago

Per chat, going forward I will be pursuing the second option, both ExpandableGroup.js and Expandable.js, and if accordion behavior can be removed, we'll remove ExpandableGroup.js.

jimmynotjim commented 6 years ago

Stories of Accordion's death are greatly exaggerated, tis alive and well and in use at https://www.consumerfinance.gov/owning-a-home/closing-disclosure/. I've fixed the existing bug in cf-expandables and have the updates working in https://github.com/cfpb/cfgov-refresh/pull/4365