Remove data set utility - Githubissues

cfpb / capital-framework

The Consumer Financial Protection Bureau's user interface framework

https://cfpb.github.io/capital-framework/

Creative Commons Zero v1.0 Universal

54 stars 29 forks source link

Remove data set utility #877

Closed anselmbradford closed 5 years ago

anselmbradford commented 5 years ago

The data-set utility is unused in CF and I couldn't find a place where cfgov-refresh was intended to use this. There are tests in cfgov-refresh that refer to dataset, such as https://github.com/cfpb/cfgov-refresh/blob/master/test/unit_tests/js/molecules/Notification-spec.js#L28 and the VideoPlayer uses a dataset ponyfill unrelated to what's here in CF https://github.com/cfpb/cfgov-refresh/blob/master/cfgov/unprocessed/js/modules/VideoPlayer.js#L10

Removals

data-set utility.

Testing

gulp build && gulp test should pass.