Autoprefixer was not correctly being skipped for the display: inline-grid; property on the labels of our radio buttons and checkboxes. The Less step was removing the Autoprefixer control comment, so Autoprefixer didn't know to skip it. Adding the ! to the comment opening characters tells Less to keep the comment in so Autoprefixer now sees it.
I also switched from the /* autoprefixer: off */ method, which required that the rule to be skipped lived in its own block, to /* autoprefixer: ignore next */, so we can do away with those extra blocks.
Changes
cf-forms: Switch from /* autoprefixer: off */ to /*! autoprefixer: ignore next */ to correctly exclude the radio & checkbox label display: inline-grid; rule from Autoprefixer
I don't think it's a side effect of this PR but I'm posting it here in case it's related: In IE helper text is inline with the label instead of below it.
Autoprefixer was not correctly being skipped for the
display: inline-grid;
property on the labels of our radio buttons and checkboxes. The Less step was removing the Autoprefixer control comment, so Autoprefixer didn't know to skip it. Adding the!
to the comment opening characters tells Less to keep the comment in so Autoprefixer now sees it.I also switched from the
/* autoprefixer: off */
method, which required that the rule to be skipped lived in its own block, to/* autoprefixer: ignore next */
, so we can do away with those extra blocks.Changes
/* autoprefixer: off */
to/*! autoprefixer: ignore next */
to correctly exclude the radio & checkbox labeldisplay: inline-grid;
rule from AutoprefixerTesting
Follow the instructions on https://github.com/cfpb/capital-framework/blob/master/CONTRIBUTING.md and view a page with checkboxes in IE, for example, inside the filter controls expandable on https://www.consumerfinance.gov/about-us/blog/.
Screenshots
Before
After
Checklist
Testing checklist
Browsers