cfpb / capital-framework

The Consumer Financial Protection Bureau's user interface framework
https://cfpb.github.io/capital-framework/
Creative Commons Zero v1.0 Universal
55 stars 29 forks source link

Fix checkbox and radio button grid stuff in IE #900

Closed Scotchester closed 5 years ago

Scotchester commented 5 years ago

Autoprefixer was not correctly being skipped for the display: inline-grid; property on the labels of our radio buttons and checkboxes. The Less step was removing the Autoprefixer control comment, so Autoprefixer didn't know to skip it. Adding the ! to the comment opening characters tells Less to keep the comment in so Autoprefixer now sees it.

I also switched from the /* autoprefixer: off */ method, which required that the rule to be skipped lived in its own block, to /* autoprefixer: ignore next */, so we can do away with those extra blocks.

Changes

Testing

Follow the instructions on https://github.com/cfpb/capital-framework/blob/master/CONTRIBUTING.md and view a page with checkboxes in IE, for example, inside the filter controls expandable on https://www.consumerfinance.gov/about-us/blog/.

Screenshots

Before

Screen Shot 2019-03-28 at 16 48 49

After

Screen Shot 2019-03-28 at 16 49 05

Checklist

Testing checklist

Browsers

contolini commented 5 years ago

I don't think it's a side effect of this PR but I'm posting it here in case it's related: In IE helper text is inline with the label instead of below it.

21c8d980-5797-11e9-9c8f-29d5d6fefdd8

anselmbradford commented 5 years ago

@contolini https://github.com/cfpb/capital-framework/pull/631#issuecomment-353662165