search

cfpb / capital-framework

The Consumer Financial Protection Bureau's user interface framework
https://cfpb.github.io/capital-framework/
Creative Commons Zero v1.0 Universal
54 stars 29 forks source link

Add missing icons #919

Closed anselmbradford closed 5 years ago

anselmbradford commented 5 years ago

The doc templates include some icons, but the CSS ALSO references some icons. The includes are in _includes, but the CSS references dist, so we need an additional copy there. It would be nicer if this didn't fail silently when the icons are missing and it would also be nice not to require duplicate copies.

Additions

Testing

  1. Pull this branch down.
  2. cd docs && gulp && bundle exec jekyll serve
  3. /components/cf-forms/ should have checks in the checkboxes, and a down arrow in the select menus.
anselmbradford commented 5 years ago

Hmm... is this only a problem with the docs? We probably need to think harder about how these icons get where they need to go if someone is adding cf-forms to a new project.

Turns out this is a problem when ccdb5-ui tries to update cf-forms too! 👀