cfpb / capital-framework

The Consumer Financial Protection Bureau's user interface framework
https://cfpb.github.io/capital-framework/
Creative Commons Zero v1.0 Universal
54 stars 29 forks source link

Update Featured Content Module styling #930

Closed Scotchester closed 5 years ago

Scotchester commented 5 years ago

This PR implements several desired styling updates for Featured Content Modules. See https://GHE/CFGOV/platform/issues/3087 for background.

/cc @designlanguage @keelerr

Removals

Changes

Testing

  1. Check out a working branch
  2. Run gulp docs
  3. Go into the documentation directory with cd docs
  4. Run bundle exec jekyll serve and visit http://localhost:4000/components/cf-layout/#featured-content-module
  5. Go into responsive mode and view the FCM at various window widths

Screenshots

Before

Screen Shot 2019-06-06 at 13 12 40

After

Screen Shot 2019-06-06 at 13 13 33

Todos

Checklist

Testing checklist

Browsers

Accessibility

Other

Scotchester commented 5 years ago

@anselmbradford Thanks for the review! I believe I have addressed all your feedback. Ready for re-review.

P.S.: I still want to do a little more cross-browser testing. I see an issue in IE9 already 😩

Scotchester commented 5 years ago

I think this is good to go. Fixed the IE9 bug by adding an explicit top: 0; to the visual's absolute positioning. @anselmbradford, any final comments?