search

cfpb / cfpb.github.io

A site for the CFPB to share and discuss its technology work with the world.
https://cfpb.github.io/
Creative Commons Zero v1.0 Universal
362 stars 98 forks source link

Mortgage toolkit article #66

Closed ielerol closed 9 years ago

ielerol commented 9 years ago

Here's the mortgage toolkit article, the last of the three KBYO articles. You can preview the page here: http://ielerol.github.io/cfpb.github.io/articles/your-home-loan-toolkit/

KimberlyMunoz commented 9 years ago

LGTM, Can you add semantic line breaks to make any future edits/PRs easier to review?

https://github.com/cfpb/front-end/blob/master/markup.md#semantic-line-breaks-in-source-code

mebates commented 9 years ago

@ielerol - the crops on the first two images are incorrect. They should look more like what's in the google doc (much more zoomed in). Do you need me to make new files for you?

ielerol commented 9 years ago

@mebates sorry, I took those images from the google drive folder without checking them. I have the cropped version as well since I eventually figured out how to get them directly from the google document, I'll swap those out.

ielerol commented 9 years ago

@KimberlyMunoz thanks! I added semantic line breaks, and updated the images to the correct versions.

mebates commented 9 years ago

@ielerol can we make sure that they're the color corrected shots? i'll chat you the correct link

ielerol commented 9 years ago

ok, this time featuring correctly cropped AND color-corrected images, @mebates has confirmed.

KimberlyMunoz commented 9 years ago

:+1: