marcesher
commented
10 years ago @virtix @dlapiduz
I've got an idea that will address this and #12 . It'll be a fairly significant addition to clouseau, but it will not change any existing behavior.
Short version: I want to add the ability to inspect a range, such as the current commit, or all commits that are part of a pull request. This would use git log and git diff instead of git grep. It'd put the results into the same format that we're using with the output of git grep and consequently those results would still feed into the existing clients.
Why not git grep for this?
Because git grep isn't clever enough to inspect just the changes between a range of commits. Rather, it inspects the entire tree. Consequently, the same findings are going to come up, over and over.
How will this work?
I'll write a new function that accepts a range. Default would be HEAD and HEAD~1. For a pull request, you could pass "master" and "origin/pr/162", for example.
- It would use git log to get the commit messages for the range:
git log --pretty=format:"%B" -1 for the current commit
git log origin/pr/162 master --pretty=format:"%B" to get all commit messages that are part of a pull request
Then, for each term, we would loop over the lines and detect that term's presence. Findings get added to the result data
- For each term from the patterns files, it would use git diff to find diffs containing that term:
git diff HEAD~1 HEAD -Sspecifiied --unified=0 --minimal -w to find the term 'specifiied' in the current commit, which produces output like:
<clouseau> (master)$ git diff HEAD~1 HEAD -Sspecifiied --unified=0 --minimal -w
diff --git a/clouseau/clouseau.py b/clouseau/clouseau.py
index d307f15..1b71294 100755
--- a/clouseau/clouseau.py
+++ b/clouseau/clouseau.py
@@ -100 +100 @@ class Clouseau:
- help="If specifiied, skips any calls to git-clone or git-pull.")
+ help="If specified, skips any calls to git-clone or git-pull. Useful in combination with --dest to test a local git repo")git diff origin/pr/162 master -Svalue --unified=0 --minimal -w for a pull request to get a diff of anything containing the word 'value', which produces output like:
diff --git a/resources/static/js/data-api.js b/resources/static/js/data-api.js
index 23b9284..22171cb 100644
--- a/resources/static/js/data-api.js
+++ b/resources/static/js/data-api.js
@@ -5,0 +6 @@
+ .chain()
@@ -12 +13,2 @@
- }, {});
+ }, {})
+ .value();
@@ -21 +23,3 @@
- var formString = _(formVals).pairs()
+ var formString = _(formVals)
+ .chain()
+ .pairs()
@@ -25,0 +30 @@
+ .value()Ideally, git grep would get us all this but I can't see a way to do that. Obviously, this isn't as clean as git grep, and it'll be a fair bit of work to parse these outputs, which is why I wanted to propose this approach before implementing.
It'd be useful to run clouseau locally as a pre-commit hook. It would not prevent commits, but it'd give people an opportunity to amend the commit before pushing, should something untoward be found.