search

cfpb / clouseau

⚠️ THIS PROJECT IS DEPRECATED ⚠️ Search your repository's git history for undesirable text patterns such as passwords, ssh keys and other personal identifiable information
Creative Commons Zero v1.0 Universal
97 stars 26 forks source link

use tox to run tests against Python2.7 and 3.4 #34

Closed rosskarchner closed 5 years ago

rosskarchner commented 8 years ago

Per @catherinedevlin's suggestion in #32-- we should support Python 3. This PR helps us track that work, by using tox to run our tests against Python 2.7 and 3.4, and configuring travis to use tox.

Potential controversy: tox doesn't play well with nose-progressive, so I've disabled it and removed it from the requirements. Does anyone care?

rosskarchner commented 8 years ago

Travis failure is by design ;)

marcesher commented 8 years ago

@rosskarchner Shouldn't we maybe add in the python 3 support before failing builds due to its absence?

Also, let's talk about the plan for adding python 3 support this week.

rosskarchner commented 8 years ago

I'm not too opinionated about that-- but it doesn't seem like an unreasonable way to set the bar we want to meet.

I've fixed the branch so that testing against Python 3.4 is optional, and can be invoked with:

tox -e py34