cfpb / college-costs

⚠️ Deprecated: see note. ⚠️ A tool to help students weigh the costs and rewards of a college program.
https://www.consumerfinance.gov/paying-for-college2/understanding-your-financial-aid-offer/about-this-tool/
50 stars 27 forks source link

NPM security updates and correction for hiding/showing offer sections #218

Closed marteki closed 8 years ago

marteki commented 8 years ago

This updates versions for our NPM front-end packages, and corrects an error where the snyk security policy was set to be ignored by Git.

It also corrects the dynamic hiding/showing of offer sections based on URL values to only apply to the anticipated total direct cost and tuition payment plans.

Additions

Pull down the branch. Try a full setup.sh to get a fresh copy of the code.

Try setting the total direct cost to 0 in the URL. Try removing it. Try setting the tuition payment loan amount to 0 in the URL. Try removing it. Try setting anything else to 0 in the URL, or removing it. The sections should still remain.

All unit tests should pass. Our NPM security tests should pass. Browser tests are still not all passing, but have improved their failure rate.

Review

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 99.016% when pulling 81ed6db3733cb549425c43448a30698a36c61842 on npm-and-hiding into e960f8b974a22c9ba01bfbcc1f7221a9e81cbdfa on master.

amymok commented 8 years ago

Looks good to me!

mistergone commented 8 years ago

batman-thumbs-up

marteki commented 8 years ago

Merging. :-)