This updates versions for our NPM front-end packages, and corrects an error where the snyk security policy was set to be ignored by Git.
It also corrects the dynamic hiding/showing of offer sections based on URL values to only apply to the anticipated total direct cost and tuition payment plans.
Additions
npm prune to setup.sh before npm shrinkwrap
Removals
.snyk reference from .gitignore, so everyone can share the same updated security policy!
Changes
Only hide total direct cost and tuition payment plans if the URL value is $0 or missing entirely. Show all other sections as applicable (based on program or loan availability).
Add missing values in worksheet.html
Testing
Pull down the branch. Try a full setup.sh to get a fresh copy of the code.
Try setting the total direct cost to 0 in the URL. Try removing it.
Try setting the tuition payment loan amount to 0 in the URL. Try removing it.
Try setting anything else to 0 in the URL, or removing it. The sections should still remain.
All unit tests should pass.
Our NPM security tests should pass.
Browser tests are still not all passing, but have improved their failure rate.
Review
@mistergone @higs4281 @amymok
Checklist
[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
Coverage remained the same at 99.016% when pulling 81ed6db3733cb549425c43448a30698a36c61842 on npm-and-hiding into e960f8b974a22c9ba01bfbcc1f7221a9e81cbdfa on master.
This updates versions for our NPM front-end packages, and corrects an error where the
snyk
security policy was set to be ignored by Git.It also corrects the dynamic hiding/showing of offer sections based on URL values to only apply to the anticipated total direct cost and tuition payment plans.
Additions
npm prune
tosetup.sh
beforenpm shrinkwrap
Removals
.snyk
reference from.gitignore
, so everyone can share the same updated security policy!Changes
worksheet.html
Testing
Pull down the branch. Try a full
setup.sh
to get a fresh copy of the code.Try setting the total direct cost to
0
in the URL. Try removing it. Try setting the tuition payment loan amount to0
in the URL. Try removing it. Try setting anything else to0
in the URL, or removing it. The sections should still remain.All unit tests should pass. Our NPM security tests should pass. Browser tests are still not all passing, but have improved their failure rate.
Review
Checklist