Miscellaneous static and dynamic content updates

[marteki]

This fixes errors in the static content and error messaging for the tool. It also adjusts the dynamic showing/hiding for job placement rates and program type to address bugs.

Additions

• Missing words or periods as needed per the rules of English grammar 😄

  Removals

• Content that has been removed due to negotiations

  Changes

• Adjusts the criteria for dynamic showing/hiding of job placement rates
• Adjusts how to determine whether a program offers a degree or a certificate

  Testing

Pull down the branch, and load up a sample URL on localhost.

• If more than the allowed amount is inputted for military tuition assistance, the error message should use the word 'awarded' instead of 'borrowed'.
• The content in the Step 1 Federal Loans section about tax burdens and tax advisors should be gone.
• The content at the end of Step 1 should state "Think about how borrowing $X,XXX this year will affect your future finances" instead of "Think about how $X,XXX this year will affect your future finances".
• The sentence in Step 2 that ends with "to borrow money to purchase a car or a home" should end in a period.
• If not given by the school, the job placement rate paragraph should be hidden, and you should not see a NaN% value in Step 2 for it.
• The question between Step 2 and Step 3 should accurately display whether the program offers a degree or offers a certificate.

All JS unit tests should pass. After some package updates and patching, our NPM security test should pass. Functional browser tests are still not passing. They will be re-evaluated and refactored in a coming PR.

Review

• @mistergone @higs4281 @amymok @anselmbradford

  Checklist

• [x] Changes are limited to a single goal (no scope creep)
• [x] Code can be automatically merged (no conflicts)
• [x] Code follows the standards laid out in the front end playbook
• [ ] Passes all existing automated tests
• [x] New functions include new tests
• [x] New functions are documented (with a description, list of inputs, and expected output)
• [x] Placeholder code is flagged
• [x] Visually tested in supported browsers and devices
• [x] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

[marteki]

The content at the end of Step 1 should state "Think about how borrowing $X,XXX this year will affect your future finances" instead of "Think about how $X,XXX this year will affect your future finances".

For some reason, the dynamic paragraphs for positive/negative cost remaining aren't showing up for me anymore. 😞 I'm filing a bug on our tracker to look into this more.

[coveralls]

Coverage remained the same at 99.386% when pulling ad787c7c742af09c76246b9f2c0b257f16967a39 on content-content-content into 83578eea9334dc2d2b9754cbcc277e81d9ed56f0 on master.

[mistergone]

LGTM, aside from the bug you mentioned above.

[higs4281]

• npm tests pass with 4 vulns
• all content test points pass, but I see NaN for this PR where build shows a value.

on build:

this PR in standalone:

[coveralls]

Coverage increased (+0.4%) to 99.766% when pulling ad787c7c742af09c76246b9f2c0b257f16967a39 on content-content-content into 83578eea9334dc2d2b9754cbcc277e81d9ed56f0 on master.

[mistergone]

@higs4281 I'm not seeing the same NaN. There's no migrate or anything to do, is there?

[marteki]

@higs4281 I also can't replicate that with that program. I'm not even seeing the same number with the default aid offer on build.

Are you inputting any modifications to the given aid offer? If so, what are they, so we can see what might be triggering the NaN for you?

[higs4281]

Just copied the string from build:

http://localhost:8000/paying-for-college2/understanding-your-financial-aid-offer/offer/?iped=210960&pid=44&oid=fa8283b5b7c939a058889f997949efa566c616a3&book=1500&gib=0&gpl=0&hous=5611&insi=5.0&insl=3000&inst=36&mta=0&othg=100&othr=6079&parl=7000&pelg=1500&perl=5500&ppl=0&prvl=2000&prvf=2.1&prvi=4.55&schg=2000&stag=2000&subl=3500&totl=91004&tran=500&tuit=16360&unsl=2000&wkst=1000

[marteki]

Same. After a manage.py migrate, manage.py loaddata collegedata, and gulp, this is what I see on localhost with no aid offer inputs or adjustments:

and

Are you seeing at least the first screenshot? Is our data the same?

[higs4281]

Top is same. must be something local for me.

[higs4281]

rebuilt branch and got same result. something's odd with that program. here's what I see for Step 1 big picture on build.

[marteki]

Pull this branch again. I merged in the adjustments you just merged for program length. Otherwise, no program length is set in the dropdown, and that has ripple effects down the page for calculations.

[marteki]

And build won't have that working until the Jenkins job is rebuilt.

[higs4281]

I say ignore my issues. The program data for that example is wildly different from the offer data. Let me get those more in line in the sample URL, but don't let this hold up the PR. 👍

[marteki]

Merging!