Updates header to latest markup

cfpb / college-costs

⚠️ Deprecated: see note. ⚠️ A tool to help students weigh the costs and rewards of a college program.

https://www.consumerfinance.gov/paying-for-college2/understanding-your-financial-aid-offer/about-this-tool/

50 stars 27 forks source link

Updates header to latest markup #240

Closed anselmbradford closed 8 years ago

anselmbradford commented 8 years ago

Changes

Updates header markup to latest from cfgov-refresh.
Testing
gulp build
Header should be correct at all sizes.
There shouldn't be any header-related errors in the JS console.
Review
@marteki
@higs4281
@mistergone
Screenshots

screen shot 2016-07-29 at 6 18 40 pm

Notes

This has absolute URLs for the images, which doesn't seem like how it should be in production, but that's how it was before so I left it.

coveralls commented 8 years ago

Coverage remained the same at 100.0% when pulling 7f2af38fefb037e37a0d88da799ef832bed422d0 on update_header into cfed75e9a788238df404bb80fe88de928c9971fd on master.

higs4281 commented 8 years ago

👍 Thank you for this, Ans.

The absolute URLs are solely for standalone mode. In production we inherit the real header.

mistergone commented 8 years ago

Thanks, @anselmbradford !

colbert-thumbs-up

marteki commented 8 years ago

All the 👍 s I have. Awesome!

cfpb / college-costs

Updates header to latest markup #240

Changes

Testing

Review

Screenshots

Notes