Tweak program loader to handle most likely error

cfpb / college-costs

⚠️ Deprecated: see note. ⚠️ A tool to help students weigh the costs and rewards of a college program.

https://www.consumerfinance.gov/paying-for-college2/understanding-your-financial-aid-offer/about-this-tool/

50 stars 27 forks source link

Tweak program loader to handle most likely error #242

Closed higs4281 closed 8 years ago

higs4281 commented 8 years ago

Try as we might to require utf-8 CSVs, it is inevitable that some schools (including EDMC) will send us CSVs straight out of Excel, encoded in windows-1252.

Changes

Tweaks load_programs and related tests
Review
@amymok
Checklist
[x] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

coveralls commented 8 years ago

Coverage remained the same at 100.0% when pulling 12f8de8983f7aa93b1a758779f7b77fbd2aee2c9 on program-loader into cfed75e9a788238df404bb80fe88de928c9971fd on master.

amymok commented 8 years ago

Ah hopefully this encoding works better :) Looks great to me!

saintsoup52 commented 8 years ago

I don't understand this... but as someone who does his URL building in Excel, I am glad we are doing this.

cfpb / college-costs

Tweak program loader to handle most likely error #242

Changes

Review

Checklist