Fix test when using locale middleware

willbarton commented 7 years ago

When running the college-costs tests with https://github.com/cfpb/cfgov-refresh/, the django locale middleware is loaded. That middleware chokes trying to modify the headers of the original MagicMock it got instead of a Response object. This PR removes the mocking of render_to_response and mocks the feedback object creation instead.

Part of GHE/CFGOV/platform/issues/798

Changes

Fix a test that was failing when run as part of https://github.com/cfpb/cfgov-refresh/

Testing

Checkout https://github.com/cfpb/cfgov-refresh/
pip install git+https://https://github.com/cfpb/college-costs.git@holistic-tests
tox -e optional

Checklist

[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the front end playbook
[ ] Passes all existing automated tests
[ ] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling cc151cf52ea41afe738f27388f579d6096dea8fd on holistic-tests into 0a2dda83381db676e2895f4227d8c06c00d0f6e2 on master.

higs4281 commented 7 years ago

Wouldn't #299 make a handsome pairing for a release? ??

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 8c27c4e5e4ce7ef8f6b873c7ed80d45662ace109 on holistic-tests into 0a2dda83381db676e2895f4227d8c06c00d0f6e2 on master.

cfpb / college-costs