Definition lists aren't stacking properly (see GHE platform issue 1054)
Browser forcing auto-scroll down in small screen (see GHE platform issue 1055)
Tab navigation within budgeting worksheet wipes out edits(see GHE platform issue 1056)
Spacing misalignment for a
within a
(see GHE platform issue 1057)
Changes
Added some LESS so that dd and dt stack as originally intended in the verification section
Disabled the sticky-kit.js events when the screen is smaller than 600px wide. This fixes the chaotic auto-scrolling issue.
Rewrote the keyup handler for the Expenses section so that it matches the code for the financial section. This fixes the issue with tabbing wiping out edits.
Added LESS to fix the margin-bottom on the p:last-child elements. (This was caused by cascading styles bleeding in from header.css and footer.css.)
Testing
Pull down and install college-costs as directed in the README. Then look at the internal issues listed above and check my fixes!
IMPORTANT NOTE: college-costs does NOT work with node 8, and gulp commands will not work under node 8. Since many of our other apps now use node 8, be sure you are using node 6. (I have not tested in any other node versions).
Review
@sebworks has promised to check my code
@marteki - if possible, I would like for you to review the work and give it a thumbs-up.
Todos
The app should be updated to work in node 8 at some point. This might be as simple as updating gulp, but I didn't look into it.
Checklist
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
Coverage remained the same at 100.0% when pulling 9c1969b29aaecef910cdc9eed01c4f98b7355892 on fixes into c0d7041fa22af606b4c179532d488942f4b82003 on master.
Coverage remained the same at 100.0% when pulling 905fb7c5e86f673022cb8afba6748f9843805ab8 on fixes into c0d7041fa22af606b4c179532d488942f4b82003 on master.
This pull request fixes four bugs in the tool:
within a
Changes
ddanddtstack as originally intended in the verification sectionsticky-kit.jsevents when the screen is smaller than 600px wide. This fixes the chaotic auto-scrolling issue.keyuphandler for the Expenses section so that it matches the code for the financial section. This fixes the issue with tabbing wiping out edits.margin-bottomon thep:last-childelements. (This was caused by cascading styles bleeding in fromheader.cssandfooter.css.)Testing
college-costsas directed in the README. Then look at the internal issues listed above and check my fixes!college-costsdoes NOT work with node 8, andgulpcommands will not work under node 8. Since many of our other apps now use node 8, be sure you are using node 6. (I have not tested in any other node versions).Review
Todos
gulp, but I didn't look into it.Checklist
Coverage remained the same at 100.0% when pulling 9c1969b29aaecef910cdc9eed01c4f98b7355892 on fixes into c0d7041fa22af606b4c179532d488942f4b82003 on master.
I don't think the shrinkwrap should change.
Coverage remained the same at 100.0% when pulling 905fb7c5e86f673022cb8afba6748f9843805ab8 on fixes into c0d7041fa22af606b4c179532d488942f4b82003 on master.
@sebworks approved my additional changes, so I am now merging!