Modernizes build - Githubissues

cfpb / college-costs

⚠️ Deprecated: see note. ⚠️ A tool to help students weigh the costs and rewards of a college program.

https://www.consumerfinance.gov/paying-for-college2/understanding-your-financial-aid-offer/about-this-tool/

50 stars 27 forks source link

Modernizes build #322

Closed anselmbradford closed 6 years ago

anselmbradford commented 6 years ago

Someone with familiarity with college-costs should try this out. I'm not sure exactly what to check.

Changes

Convert browserify config to webpack.
Remove unused dependencies.
Update ESLint config to version 5.
Fix linter errors.
Convert to ES6 syntax.
Add linting to Travis config.

Testing

https://github.com/cfpb/college-costs#installation should work (specifically ./standalone_setup.sh).
npm test should pass.
gulp lint should not have errors (it will have warnings).
The protractor tests in https://github.com/cfpb/college-costs#running-tests don't pass for me, but it looks like maybe I need an API running. Anyone able to check?

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling 69c3f7e3c9ce0458a49ac8e06c19787ed68805b8 on update_deps into 3a4d6af4d3e52870baf822dbcfe4eb24583f8e5d on master.