Fixes Functional Testing

mistergone commented 6 years ago

This pull request fixes functional tests in the repo. It also addresses style issues introduced by the upgrade to Capital Framework 7.

Additions

Adds functions to expose values to the browser from inside the financial model and the expenses model
Adds a number of utility functions that make writing tests easier

Changes

Changes some javascript and styles to address failing functional tests
Fixes the hero to work with capital-framework@7

Testing

Following the guide for running functional tests outlined in the JavaScript testing section of the README.

Review

@chosak

Notes

One test is temporarily 'pending' because it only works some of the time. I hope to address this soon, but this shouldn't hold up this PR and the PRs which depend on it.

Checklist

[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows the standards laid out in the front end playbook
[x] Passes all existing automated tests
[x] New functions include new tests
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged
[x] Visually tested in supported browsers and devices
[x] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling ba71685e34d746e23907d538554a9d6d6e17e4ed on functional-fixes into 1a239ddb80bb1ee9bd2807a3e76dcc7b65da7d70 on master.

schbetsy commented 6 years ago

I'm afraid something about my setup is wrong, because I'm getting failures when I try to run the tests on this branch.

Sometimes the output looks like this:

> protractor test/functional/conf.js
[09:55:14] I/launcher - Running 1 instances of WebDriver
[09:55:14] I/hosted - Using the selenium server at http://localhost:4444/wd/hub
Started
.....F.................................F......FF......FFF.FFF.*...F......F.F.............

And other times it's like this:

.....F.................................F......FF..............*..........FA Jasmine spec timed out. Resetting the WebDriver Control Flow.
A Jasmine spec timed out. Resetting the WebDriver Control Flow.
FA Jasmine spec timed out. Resetting the WebDriver Control Flow.
A Jasmine spec timed out. Resetting the WebDriver Control Flow.
A Jasmine spec timed out. Resetting the WebDriver Control Flow.
FA Jasmine spec timed out. Resetting the WebDriver Control Flow.
A Jasmine spec timed out. Resetting the WebDriver Control Flow.
A Jasmine spec timed out. Resetting the WebDriver Control Flow.
FA Jasmine spec timed out. Resetting the WebDriver Control Flow.
[then it starts taking forever so i ctrl-c to stop it]

For reference, ./standalone_setup.sh ran without errors, and the django server log doesn't show any errors.

In case it's relevant, here are some versions of things I have:

> node -v
v8.11.3

> npm -v
5.6.0

> webdriver-manager version
[10:05:25] I/version - webdriver-manager 12.1.0

Any idea what's going on there?

cfpb / college-costs