cfpb / college-costs

⚠️ Deprecated: see note. ⚠️ A tool to help students weigh the costs and rewards of a college program.
https://www.consumerfinance.gov/paying-for-college2/understanding-your-financial-aid-offer/about-this-tool/
50 stars 27 forks source link

Change functional test parameters, update to jQuery3 #331

Closed mistergone closed 6 years ago

mistergone commented 6 years ago

This code will update the functional tests to use a school from the default data (collegedata.json) rather than the test data (test_program.json) to avoid extra steps in making those functional tests work.

It also updates jQuery in the application from 1.11.3 to 3.3.1.

Changes

Testing

Review

Notes

Todos

Checklist

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling c391925dd3964c66ecf114a8e40fcbd9e72cfddc on no-really-the-functional-tests-are-fixed-now-seriously into 8826655141c65e58fdcd4d20048d5c1d99299747 on master.

schbetsy commented 6 years ago

This is passing for me, when I remove the fit*! And it looks to be more stable than the previous version (I've done a few trial runs and haven't seen any intermittent failures so far).

(* There's still one failure, where it tries to open an 3rd party site and times out. As we discussed, we're adding a backlog task to keep the functional tests from doing that, so I'm not worried about it here.)