cfpb / consumerfinance.gov

Django project protecting American consumers
https://www.consumerfinance.gov/
Creative Commons Zero v1.0 Universal
276 stars 112 forks source link

Fix (for real) the before-you-claim tests in time #8563

Closed willbarton closed 1 month ago

willbarton commented 1 month ago

8552 froze the before-you-claim functional tests in time, but I missed a few things.

We're still a couple years out from when our API intercept date URLs were set to. This means we were testing directly against the API endpoint instead of getting a mock response. This was causing intermittent failures.

I also think the "under 50" tests have probably been hitting the actual API endpoint as well for a while — there seems to be a mistake here in the intercept target date, 1969 instead of (now) 1959.

I also tried to be clever with the month, but that was unnecessary.

Checklist