Limit review size and catch bad JSON - Githubissues

cfpb / curriculum-review-tool

An interactive tool that allows a teacher to assess the merits of a financial education curriculum.

https://www.consumerfinance.gov/practitioner-resources/youth-financial-education/curriculum-review/

Creative Commons Zero v1.0 Universal

10 stars 14 forks source link

Limit review size and catch bad JSON #419

Closed mrclay closed 3 years ago

mrclay commented 3 years ago

Limits the acceptable size of review entry and formally catches JSONDecodeError instead of litting Django deal with it.

Additions

Returns 400 status if request body limit too large
Returns 400 status if request body is invalid JSON
Adds unit tests for those

How to test this PR

Run unit tests.

Checklist

[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code follows the standards laid out in the CFPB development guidelines
[ ] Future todos are captured in comments and/or tickets
[ ] Project documentation has been updated

mrclay commented 3 years ago

@higs4281 Do you know why these tests are failing? https://github.com/cfpb/curriculum-review-tool/pull/419/checks?check_run_id=2458486423

Scotchester commented 3 years ago

@higs4281 Do you know why these tests are failing? https://github.com/cfpb/curriculum-review-tool/pull/419/checks?check_run_id=2458486423

Looks to be because the PR was opened from a fork. Unfortunately, our CI is currently not set up to handle that scenario.

You have permission to push your branch to the @cfpb repo; please do that and reopen the PR from there.