cfpb / design-manual

⚠️ THIS REPO IS DEPRECATED ⚠️ A set of design principles and standards for the Consumer Financial Protection Bureau.
https://cfpb.github.io/design-manual/
Creative Commons Zero v1.0 Universal
98 stars 71 forks source link

Tabs Design Manual page #352

Open Dnpizarro opened 9 years ago

Dnpizarro commented 9 years ago

Working from @keelerr outline for the Tabs design manual page, I'll start mocking up the visuals and laying out the content.

Stay posted on page designs....

Dnpizarro commented 9 years ago

@keelerr here is the most recent mock-up I showed during our Working Session. I'll keep working on the design, while you try to shorten some of the bullet points. Also, for the link under the image, should we show the full url or just the label (i.e. Form explainer)? I believe our standard is to show the url so that the user knows where they are going. Also on that note, if we decide to show the url I'm not sure if we need to add the external link minicon...

ui-toolkit_tabs_dm_page_r1_tabs-01_tabs-01

Dnpizarro commented 9 years ago

@keelerr the designs below include all of the content provided in outline document. I made some suggestions to simplify a couple of the headers ( "Tab usage" = "Usage", "1. To show alternate..." = "Use case 1: Show alternate..."). There are still some areas that could use some cutting back on content, but I wanted to show this full view as you edit it down. Also, one thing that I just realized is that I should include some illustrated measurements for how the tabs should be styled (i.e. height of tab, padding, etc)

ui-toolkit_tabs_dm_page_tabs-01

kurzn commented 9 years ago

I just ran across this implementation of tabs on Paying for College: expandables as tabbed interaction. Can we add a comment in the tabs rules about NOT doing this, please?

http://www.consumerfinance.gov/paying-for-college/choose-a-student-loan/#o1

image

benguhin commented 9 years ago

@kurzn I totally agree. That said, we could have very long pages if we try to detail everything that people should not do :)

I think the rules for the expandable sections pattern will help make sure that that interaction doesn't happen again

benguhin commented 9 years ago

Similar to @Scotchester's comment about tooltips, I don't think we should standardize the use of minicons instead of text for the name of each tab. Iconography and hover states are not clear enough indicators of what's underneath the tab.

Dnpizarro commented 9 years ago

Latest update for Friday Presentation

ui-toolkit_tabs_dm_page_r2_tabs

nataliafitzgerald commented 9 years ago

@Dnpizarro @keelerr - I don't think that I agree with including the minicon tabs as a standard. Also, the OaH tabs are taller than the standard you have set forth. So, for the image I would rather see tabs that are following the guidelines you are proposing. If you'd like to chat through this I'm available.

Dnpizarro commented 9 years ago

Update 9/14

@nataliafitzgerald sorry for not updating this issue sooner, but we are definitely not including the minicon tab as a standard. In the mockup below, under the section "Use" I plan on showing live versions of the tabs. I included some lorem ipsum to fill in the example. Also, I included some questions in the mockup, particularly the one about whether we should consider numbering the tabs in the "Navigate a process" example.

ui-toolkit_tabs_dm_page_r3_tabs

nataliafitzgerald commented 9 years ago
keelerr commented 9 years ago

@nataliafitzgerald and @Dnpizarro, I've tried to respond to your points:

  1. I think the introductory sentence should stay in the introduction. I don't think we need any more preamble before jumping into the use case. (And this is what's included in my current draft of the content.)
  2. I think using tabs to step users through a process is a valid use case. This is why I've included it. To help me clarify and improve this section, can you tell me what seems complicated about it?
  3. Thanks for the wording suggestion. I like including "to" in each use case. So, it would be "To show alternate views of the same information" and "To navigate through a process."
  4. I think it would be more helpful to include examples rather than the generic "tab 1" and "tab 2." Is there a reason we've moved away from the CFPB examples? I think it provides helpful context. And, the example link you're showing under "To show alternate views..." is really to illustrate "To navigate through a process". This might help clarify @nataliafitzgerald's concern about the 2nd use case. If they didn't look identical, it might be easier to distinguish why there are 2 use cases.
  5. I agree the black is heavy, but I think including "Step 1" and "Step 2" may also become problematic. With tight character counts, this may not leave enough space to include a descriptive word/phrase explaining what the step is! @Dnpizarro, I think it's helpful to include numbering. I don't think we have to mandate it be included, but I'd love the example to show some numbering...
  6. Do we just want to eliminate this section all together? (It should read: Use name anchors. Consider...)
nataliafitzgerald commented 9 years ago

@Dnpizarro - If you include numbers you can look at a different coloring for the minicon circle or use numbers without circles.

Dnpizarro commented 8 years ago

I started coding the DM page, see below. I will post screenshots of the examples tomorrow. @keelerr not sure were we landed on the "Technical considerations," did we still want to include that? Also, the links connecting to the code still need to be corrected. @Scotchester would you be able to provide those links for me?

http://dnpizarro.github.io/design-manual/ui-toolkit/tabs.html

Dnpizarro commented 8 years ago

@keelerr and @nataliafitzgerald what are your thoughts on having the example go full width in the main content area after the use case explanation. The bullet points would go after the example. Additionally, @keelerr and I discussed the possibility of defining the bottom of the tab with a rule line. For clarity, the rule just above the bullets is the tab's bottom rule line. An alternate option would be to just switch the example with the bullets. Let me know your thoughts.

FYI, I cropped it intentionally to highlight the use case examples.

ui-toolkit_tabs_dm_page_r4_tabs

keelerr commented 8 years ago

@Dnpizarro, in answer to your questions:

nataliafitzgerald commented 8 years ago

In terms of "Alternate views of the same information" I can think of a lot of examples of tabs used to show multiple views in tables or charts. Would tables or charts be a good use case for this DM issue or are you looking for a more text based example.

Here are two examples from Fitbit:

Weight over time Steps over time
screen shot 2015-09-28 at 4 39 38 pm screen shot 2015-09-28 at 4 40 53 pm
KimberlyMunoz commented 8 years ago

Something I just discovered this week is that WAI-ARIA outlines the intended interactions for things like tabs. It's worth reading and perhaps linking to under the technical considerations.

https://www.w3.org/TR/wai-aria-practices-1.1/#tabpanel

We should be programming keyboard interactions to have screenreader users navigate according to the spec.

caheberer commented 7 years ago

The recommendation from this is to not use tabs...EVER. So should we even include tabs in the Design Manual?

caheberer commented 7 years ago

@keelerr will take a look at the language to reaffirm that we shouldn't use tabs except in extreme cases.