search

cfpb / design-manual

⚠️ THIS REPO IS DEPRECATED ⚠️ A set of design principles and standards for the Consumer Financial Protection Bureau.
https://cfpb.github.io/design-manual/
Creative Commons Zero v1.0 Universal
98 stars 71 forks source link

Updates to the hero and FCM DM pages #384

Closed jenn-franklin closed 8 years ago

jenn-franklin commented 8 years ago

Changes

Updated guidelines to reflect 15px spacing after the heading at all screen sizes. Updated example visuals to show this.

Review

@Scotchester @nataliafitzgerald

Screenshot

hero_page

jenn-franklin commented 8 years ago

I committed changes to the FCM guidelines page today. I apologize for not making all of my commits to both the hero and FCM pages before submitting this pull request. Here are the changes made to the FCM page:

FCM Changes

Updated to reflect changes made during the development process: the height of the module, size/ratio of the image, spacing after the heading, image behavior at 700px. Updated visual examples to show these changes. Changed the headline size on mobile to be H3 instead of H2, which was a typo.

Screenshot

featured content module cfpb design manual

Scotchester commented 8 years ago

Thanks! :+1:

mebates commented 8 years ago

Is there anything preventing us from adding these new pages into the nav?

Scotchester commented 8 years ago

I don't think so!

jenn-franklin commented 8 years ago

Thank you! No reservations from me.

jenn-franklin commented 8 years ago

Actually— I'm going to follow up with @jimmynotjim to double check that everything is good to go. Will post again here when ready.

jimmynotjim commented 8 years ago

Ditto my comment in 384. We should be good to go.

jenn-franklin commented 8 years ago

:+1:

stephanieosan commented 8 years ago

So, are we adding this into the nav in a different pull request, or did that already happen and I missed it?

And if we need to submit a different pull request to add it into the nav, who is up for doing that?

jenn-franklin commented 8 years ago

It hasn't happened. I'll add it to the nav and submit a PR. (Or I'll reach out to @Scotchester if I discover I don't know what I'm doing.)

Scotchester commented 8 years ago

Thanks, @huetingj!

jenn-franklin commented 8 years ago

Pull request here: #385 @Scotchester @stephanieosan