search

cfpb / design-manual

⚠️ THIS REPO IS DEPRECATED ⚠️ A set of design principles and standards for the Consumer Financial Protection Bureau.
https://cfpb.github.io/design-manual/
Creative Commons Zero v1.0 Universal
98 stars 71 forks source link

Design Manual IA #410

Closed jenn-franklin closed 8 years ago

jenn-franklin commented 8 years ago

Changes

• Changed main nav and reorganized pages • Matched file names to side-nav labels • Added redirects to point outdated URLs to new URLs

Review

@Scotchester For content, one of the following: @kurzn @sonnakim @ielerol @stephanieosan

Link for viewing

https://huetingj.github.io/design-manual/

Screenshots

screen shot 2016-05-15 at 11 12 33 pm screen shot 2016-05-15 at 11 12 42 pm screen shot 2016-05-15 at 11 12 51 pm screen shot 2016-05-15 at 11 13 00 pm screen shot 2016-05-15 at 11 18 32 pm
stephanieosan commented 8 years ago

This looks good from a content perspective!

I think we'll have to figure out whether we have a clash between the logo and our navigation once we add Data Visualization, but we can figure that out when the time comes.

@Scotchester Do you have time to take a look at this PR from a code perspective in the next couple of days? If not, we can ask @cfarm or @virginiacc to take a look.

Getting this merged in is a blocker for the V1 folks to start PR'ing their pages. cc: @duelj @ajbush

Scotchester commented 8 years ago

@stephanieosan Sorry, I will not. I'm swamped with finishing up the Auto Loans site.

virginiacc commented 8 years ago

@huetingj This all looks good to me! 👍 I made one suggestion about the structure of the redirects so they work locally. Other than that, I think it's ready to merge -- although it looks like I don't have access to do so...

jenn-franklin commented 8 years ago

thank you @virginiacc! i'll restructure the redirect this afternoon.

virginiacc commented 8 years ago

@huetingj The updates look great! I don't think file 2 is necessary -- it looks like it contains a commit message -- but if people are waiting on this PR we could merge now & take it out later...

jenn-franklin commented 8 years ago

Thanks @virginiacc! I deleted the file. @Scotchester this should be ready to merge. Thank you!