cfpb / design-manual

⚠️ THIS REPO IS DEPRECATED ⚠️ A set of design principles and standards for the Consumer Financial Protection Bureau.
https://cfpb.github.io/design-manual/
Creative Commons Zero v1.0 Universal
98 stars 71 forks source link

Text introductions #419

Closed ajbush closed 8 years ago

ajbush commented 8 years ago

What is it?

V1 is looking to add its atomic element documentation to the DM for the use of other teams. Because the primary touchpoint with these elements is through the Wagtail CMS we have focused on the components that will be encountered there. This component is actually a grouping of smaller page components and therefore the page abides by the content guidelines as much as possible but has a few differences. This page will live in the "page components" section of the updated DM.

Text introductions

niqjohnson commented 8 years ago

(I volunteered to do the UI review of this one in lieu of @schaferjh.)

This is looking really nice. As opposed to some of the confusion I had with the item introduction in https://github.com/cfpb/design-manual/issues/416#issuecomment-225245236, I understood how a text introduction is used right away. The "[t]ext introductions should be used on every page, except in cases when a hero is used" line is excellent.

I could still see a couple of suggestions I made for the item introduction being helpful here, too (real examples alongside the generic ones and swapping the lo-fi illustrations in the behavior section with higher fidelity ones). I don't think those are necessary to address before launching version 1 of this page, though.

Overall, a big 👍 on this one.

nataliafitzgerald commented 8 years ago

@duelj @ajbush

Content feedback:

Design feedback:

schaferjh commented 8 years ago

I suggest adding two intro sentences to this page to make it consistent with other pages:

The text introduction component is the standard page introduction component used across all pages that do not have a hero or item introduction.

On landing or sub-landing pages, the text introduction may be accompanied by a breakout sidebar to highlight a specific piece of content from the section.

@ajbush

schaferjh commented 8 years ago

@ajbush One very minor tweak: In the Content guidelines, final paragraph, add the word "Optional" so it reads "The optional call to action link should..."

ajbush commented 8 years ago

Updated!

schaferjh commented 8 years ago

great, ready to publish!