cfpb / design-manual

⚠️ THIS REPO IS DEPRECATED ⚠️ A set of design principles and standards for the Consumer Financial Protection Bureau.
https://cfpb.github.io/design-manual/
Creative Commons Zero v1.0 Universal
98 stars 71 forks source link

Full-width text #428

Closed ajbush closed 8 years ago

ajbush commented 8 years ago

What is it?

V1 is looking to add its atomic element documentation to the DM for the use of other teams. Because the primary touchpoint with these elements is through the Wagtail CMS we have focused on the components that will be encountered there. This component is actually a grouping of smaller page components and therefore the page abides by the content guidelines as much as possible but has a few differences. This page will live in the "page components" section of the updated DM.

Full-width text

nataliafitzgerald commented 8 years ago

@ajbush @duelj

Content edits

design

ielerol commented 8 years ago

I'm providing some UX review for the content and design of this page. I do have a couple of suggestions, mainly with the description of the component itself.

If the intent of the component is to highlight some text within a larger flow, that needs to be clearer. If the intent is for the component to cover both "vanilla" body text and featured text like a pull quote, I think those may need to be separate variations on the component. Basically, if I have a browse page with 3 paragraphs of body text plus I want to highlight a pull quote, I can't tell from this page if it should all be built of full-width text components or if there's some other "body" component that would have a full-width text component embedded in it for the pull quote.

schaferjh commented 8 years ago

@ajbush A handful of tweaks here:

ajbush commented 8 years ago

Updates made!

schaferjh commented 8 years ago

@ajbush great, ready to publish!