Adds V1 additions to Page components and Global elements sections of the manual

cfpb / design-manual

⚠️ THIS REPO IS DEPRECATED ⚠️ A set of design principles and standards for the Consumer Financial Protection Bureau.

https://cfpb.github.io/design-manual/

Creative Commons Zero v1.0 Universal

98 stars 71 forks source link

Adds V1 additions to Page components and Global elements sections of the manual #433

Closed ajbush closed 8 years ago

ajbush commented 8 years ago

This adds the following new pages

Under "Global elements"

Browse page
Document detail page
Filterable list pages
Item introduction
Landing page
Learn page
Sublanding page
Text introductions

Under "Page components"

25/75 image and text
50/50 image and text
Buttons
Contact information
Email sign-up
Filterable list control panel
Full width text
Half width link blob
Sidebar/prefooter
Wells

http://ajbush.github.io/design-manual/

ajbush commented 8 years ago

Tagging @Scotchester and @jimmynotjim to take a look and see if we're good on this.

schaferjh commented 8 years ago

This is so exciting! 💥

Scotchester commented 8 years ago

There's way too much code here to really be reviewable, but I took a quick perusal through all the pages on AJ's fork and it looks pretty good to me! We can fix any lingering issues as we discover them. :+1:

jimmynotjim commented 8 years ago

I noticed there are some broken anchor links at the top of the doc here => http://ajbush.github.io/design-manual/global-elements/text-introductions.html#style Double check all your anchor links are working as expected.

jimmynotjim commented 8 years ago

Other than the above link, everything looks good. 👍 from me once those links are fixed.

ajbush commented 8 years ago

Updated the anchor links like @jimmynotjim mentioned. There were a couple issues with missing hyphens, etc.

Scotchester commented 8 years ago

Lookin' good; thanks AJ!