cfpb / design-manual

⚠️ THIS REPO IS DEPRECATED ⚠️ A set of design principles and standards for the Consumer Financial Protection Bureau.
https://cfpb.github.io/design-manual/
Creative Commons Zero v1.0 Universal
98 stars 71 forks source link

Add tables page #437

Closed niqjohnson closed 7 years ago

niqjohnson commented 8 years ago

Add the tables page to the Design Manual (see #153)

Additions

tables

jimmynotjim commented 8 years ago

The pagination buttons look really janky. @Scotchester any ideas what's up with that?

schaferjh commented 8 years ago

Left field question/confirmation: @niqjohnson will this new tables page wholesale replace the current tables page here: https://cfpb.github.io/design-manual/page-components/tables.html? (And hopefully keep the same URL so no broken links?)

niqjohnson commented 8 years ago

@schaferjh: Yep, once this page is merged it'll replace what's at https://cfpb.github.io/design-manual/page-components/tables.html, so no current links that point there should break.

niqjohnson commented 7 years ago

@Scotchester, @jimmynotjim: Any thoughts on whether the tables page should be merged now? I tried to track down the paginator issues noted above, but I think it's just a side effect of putting the pagination in a narrow column. I don't think it detracts too much from the rest of the page, though.

jimmynotjim commented 7 years ago

Ditto Scott's comment. 👍