Closed Scotchester closed 6 years ago
@Scotchester could you show a larger screenshot of the proposed/how we'd like to do it page? I can't tell whereabouts on the page the share buttons are being added with the slice you've included.
What is the goal of adding the share buttons somewhere in the middle of content on a page? Just to place them higher up than in the prefooter? Or to associate them with a specific piece of text or other content?
My inclination is to say that we want to be purposeful in our use of share buttons and if we do expand how and where they are added, we might want to put some thinking/limits around where they can be added. I hear you saying that the sidebar/prefooter is not a sufficient solution. But I hesitate to add a module to the main content of the page that could mean share buttons show up anywhere in the main content area.
@sarahsimpson09 or @kurzn I'd be curious what your thoughts are around placement of share buttons.
Here's a zoomed-out screenshot of most of the page showing both placements:
What is the goal of adding the share buttons somewhere in the middle of content on a page? Just to place them higher up than in the prefooter? Or to associate them with a specific piece of text or other content?
Yes, the desire is to have the share buttons specifically associated with the featured activities, rather than the page as a whole.
My inclination is to say that we want to be purposeful in our use of share buttons and if we do expand how and where they are added, we might want to put some thinking/limits around where they can be added. I hear you saying that the sidebar/prefooter is not a sufficient solution. But I hesitate to add a module to the main content of the page that could mean share buttons show up anywhere in the main content area.
That's certainly an understandable perspective. In that vein, another route we could consider is something like adding an option to the Image Text 50-50 module that flips on share buttons within that module. It would only be marginally more complicated than making the Social Media module available anywhere, and it would probably improve the spacing, actually.
Hey @schaferjh @sarahsimpson09 @kurzn any more thoughts on this? Our ideal launch date is EOD Thursday.
I know Natalie is not available for the next few days, so if @sarahsimpson09 and @nataliafitzgerald don't have any further comments, then I would like to recommend we go with the integration of share buttons to an existing module, rather than adding a social media module to the options for content areas. I think the added context and improved spacing will improve the usage and layout.
It sounds like the module you need it on right now is Image Text 50-50 -- how about starting there? We can see how it performs and perhaps backlog a broader discussion around the strategy of inserting share icons associated with specific content across more modules?
Works for me!
PR is open: https://github.com/cfpb/cfgov-refresh/pull/2365
PR approved. Will leave the issue open until I update the Design Manual page for Image and Text 50/50.
Reviewing tasks associated with "share buttons" for another project... given the research outlined in #483 I'm wondering if this is still a good idea? Should we close this as unchanged? @schaferjh @Scotchester
Well, the change is already implemented in the Wagtail Image and Text 50/50 module. I think that unless we intend to reverse course and remove the option, it should still be documented as an available option.
Closing as this will be included in my forthcoming work to document Info Unit Groups.
As we prepare to launch the Spanish version of Money as You Grow in Wagtail, the team would like the ability to add a Social Media module within the main content area of a Browse page.
On a current English age-level page (which is hand-coded in the fin-ed-resources repo), the featured activities have a share links adjacent, which specifically share details about the activities themselves.
How we'd like to do it:
If this proposal were rejected, we'd be left with putting the module in the pre-footer area:
Adding the module within the pre-footer area would separate it significantly from the activities content, and it wouldn't make sense for them to share about the activities specifically anymore.
For extra credit, it'd be nice to add a new field to the module to customize the heading – in this case, to "Share activities" (or the Spanish translation).
@schaferjh @nataliafitzgerald @JenniferHoran