cfpb / design-manual

⚠️ THIS REPO IS DEPRECATED ⚠️ A set of design principles and standards for the Consumer Financial Protection Bureau.
https://cfpb.github.io/design-manual/
Creative Commons Zero v1.0 Universal
98 stars 71 forks source link

Added data-viz nav item #455

Closed jimmynotjim closed 7 years ago

jimmynotjim commented 7 years ago

Added the datavisualization item to the main navigtaion

Changes

Testing

Review

Preview this PR without the whitespace changes

Screenshots

screen shot 2017-02-17 at 11 01 33 am

Notes

Todos

Checklist

Scotchester commented 7 years ago

Uhhh, I'm going to revert this, because the page has no content yet.

caheberer commented 7 years ago

@Scotchester is this a large concern? If adding this nav item, or other small tweaks like this, allows someone to pick up the work from here, is there a reason that we can't have a blank page for a bit? I'm thinking any tiny bit of forward progress is better than none. But definitely interested in hearing your thoughts.

Scotchester commented 7 years ago

I'm not sure it's a large concern, but it doesn't feel right to be pointing to a page that is literally blank, other than the title.

Also, having the page in the navigation is not a prerequisite for being able to work on it. Since the file exists in the repo, anyone can navigate to /data-visualization/data-visualization.html and see the page.

caheberer commented 7 years ago

Gotchya. Makes sense.

jimmynotjim commented 7 years ago

The nav item was already there too, I just un-hid it.