cfpb / design-manual

⚠️ THIS REPO IS DEPRECATED ⚠️ A set of design principles and standards for the Consumer Financial Protection Bureau.
https://cfpb.github.io/design-manual/
Creative Commons Zero v1.0 Universal
98 stars 71 forks source link

Updates to hero graphic guidelines #461

Open nataliafitzgerald opened 7 years ago

nataliafitzgerald commented 7 years ago

User story

As a Designer/Developer/Content person, I want the hero guidelines to be useful and up-to-date so that I can know my options and successfully implement the pattern.

Acceptance criteria

Discussion (optional)

Related tasks:

nataliafitzgerald commented 7 years ago

I've been working on tackling all the tasks in this user story as part of a full update of the hero page. This update can be MVP and we can continue to make adjustments moving forward. My primary goals at this point are to: 1) Provide usage guidelines for members of D&D so they can successfully create heroes using the options that are currently available in Wagtail. 2) Provide editorial guidelines for content creators so they can create successful heroes that align with our content strategy/guidelines (character counts, tone, voice).

At this point I'm looking for a review from a few perspectives:

@Scotchester @jimmynotjim

@kurzn @jordanafyne @ielerol

Some questions to answer/address:

@huetingj

Here's a link to the page: http://nataliafitzgerald.github.io/design-manual/global-elements/heroes.html

If anyone would like to jump on Hangouts to discuss any of the specifics I've mentioned above I'm eager to push forward on this so I would be appreciative. Or, feel free to comment here. I'd like to get this MVP up as soon as possible so if I don't hear from people I'll start reaching out to others.

nataliafitzgerald commented 7 years ago

I spoke to @kurzn on Mattermost today. Here were some of her recommendations:

@jordanafyne has offered to take a look tomorrow morning and we will talk through any recommendations she has.

jimmynotjim commented 7 years ago

Overall looks really good and I appreciate how much detail you've included for situations like two line headings and the clear space between the text and photo content for the overlay version.

Scotchester commented 7 years ago

Reviewing now. Rather than post one giganto-comment, I think I'll do it piece-by-piece.

First:

Should the "Content guidelines" section include any explanation of the difference between a one-line heading and a two-line heading? It may not be totally self-evident.

nataliafitzgerald commented 7 years ago

@jimmynotjim

nataliafitzgerald commented 7 years ago

@Scotchester

Scotchester commented 7 years ago

OK, I would suggest adding some copy to make those first two points clear.

We could have two heading input fields, but the Hero module is already insanely complex to handle all of the different stylistic options, so I hesitate to make it more complex. I guess we can cross that bridge if we ever get to experimenting with back-end character limiting.

Scotchester commented 7 years ago

I agree that the "standard" (or most common, at least) style, the no-bleed illustration, should come first, and I agree with the suggestion to add some language about when to choose other styles.

nataliafitzgerald commented 7 years ago

@Scotchester - As part of our Platform team work @ielerol will be working on improving the experience and guidance for users within Wagtail so perhaps we can take a closer look at the complexity within this module. And, we will consider this when we (hopefully) visit the backend validation approach.

jimmynotjim commented 7 years ago

We could have two heading input fields

Oh please let's never do this. It'd probably be better to check the length of the title field and update the text field max characters with some JS than to provide users duplicate fields.

Scotchester commented 7 years ago

Oh please let's never do this. It'd probably be better to check the length of the title field and update the text field max characters with some JS than to provide users duplicate fields.

That doesn't work if there's a manual break in the heading, though, as the two-line example on Natalia's page show.

jimmynotjim commented 7 years ago

That would be a <br> in the text input right? We could include that in the character test.

jordanafyne commented 7 years ago

This looks great, and I think having character counts defined for the content is valuable.

nataliafitzgerald commented 7 years ago

@jimmynotjim @Scotchester I'm fine with whatever solution works from a dev perspective as long as it achieves the goal of alerting Wagtail users of character limits and accounts for the two variations (one line versus two line).

nataliafitzgerald commented 7 years ago

@jordanafyne

Scotchester commented 7 years ago

Image sizing

Scotchester commented 7 years ago

Whoops, forgot one for image sizing:

Scotchester commented 7 years ago

Text styling

901px and above

601–900

Accessibility

nataliafitzgerald commented 7 years ago

@jimmynotjim @Scotchester Related to character counts @bellamys shared this today

nataliafitzgerald commented 7 years ago

I made some updates based on your feedback (thank you all!) which are reflected here. I will go back through tomorrow but feel free to check it out. https://nataliafitzgerald.github.io/design-manual/global-elements/heroes.html

I started to compile a list of the suggested edits (I'll add the editorial related things tomorrow):

One line vs. two line

Image sizing and composition

Text styling

Remaining things to tackle

ajbush commented 7 years ago

Hey this is looking good @nataliafitzgerald the only thing I think we should reconsider is the limits on the amount of content in the "Two line heading" heros subheading. I understand it is done to try and keep the heros a consistent height at desktop but I feel like the current suggested limits in this screen shot are too restrictive for our content needs.

I'd strongly recommend we instead have the same maximum character count of 185 for both subheadings...

One line heading

Two line heading


Other question Also what was the thinking behind the lower 25 minimum characters for the Two line heading? Is there an existing use case you're accounting for?

nataliafitzgerald commented 7 years ago

@ajbush

Thanks for your feedback!

My goal with this next release is not to change what we've been doing but to document it with more detail. For example, our existing hero standards state that the heading should be "25 characters maximum, including spaces" and subheadings should be "185 characters including spaces." What this means is that as far as our existing guidelines (and Wagtail helper text) are concerned, the two line heading isn't even possible. Additionally our existing guidelines include no mention of bleeding heroes, photo heroes, sizing for images, etc. My goal at this point is to get the DM up to speed so that we all know what it currently possible and how to accomplish it.

Yes, maintaining a consistent height for heroes is important to the visual hierarchy (and is one of the goals of having max character counts). But, an equally important factor that goes into the character counts is to ensure that hero content serves to introduce and orient a user in a concise way without overwhelming them with a lot of text right out of the gate. Since our web pages are incredibly text heavy heroes serve an important role; a respectful resting point where a user can determine whether this is a page that they want (or dare to) to dive deeper into.

Up until this point, our main struggle has been with users exceeding the 185 max character count with subheading text in one-line heroes. Two line headings are actually not at all common on our site, there are currently only two live examples, Planning for Retirement and Owning a Home. On both of these, there is a forced break in the heading to separate the product name from a description. I suspect that this has something to do with users not knowing what product names mean (something that's been flagged a lot over the years).

In terms of the minimums in general, they were inspired by our work on Consumer Credit Trends where the content was cut in such a way that the content strategy goals and design goals of the hero graphic were no longer being met (recapping for the benefit of others). After that experience, @marteki and I realized that it would be helpful to document minimums so that content writers are clear with where they will want their content to be, when they don't have the luxury of testing things out in Wagtail like we do. In terms of the 25 character minimum for subheadings under a 2-line heading, I was trying to establish the point where anything less would create an imbalance between heading and subheading. There wasn't a specific use case so if you have any recommendations as to what that minimum count could be, let me know.

nataliafitzgerald commented 7 years ago

@jimmynotjim @Scotchester Looking back through the feedback, I think that documenting use cases for the different types of heroes (standard illustration, bleed illustration, photo) is a very good idea. But, I'd like to do this as part of a second push (to directly follow this one). As a graphic design team we've talked about the use cases for using photography versus illustration but it would be good to revisit and talk through these. We've talked about photography being a better option than illustration for more serious subject matter, for example. The use cases for bleed versus no-bleed illustration seems more compositional than anything else but a larger discussion may bring out some other thoughts.

nataliafitzgerald commented 7 years ago

@ajbush I'm double checking the counts and the minimum of 40 characters for the 2-line heading seems like a typo on my end. I'm going to look at that one again. 43 is the max for a 1-line heading so that is the point where it breaks to the second line. I suppose we could remove the minimum for the two line heading and just indicate that creating an orphan at the max width should be avoided. That could work.

screen shot 2017-03-31 at 10 06 40 am

I'll consult with @jordanafyne today to see what she thinks would be most useful for our content writers/templates.

jimmynotjim commented 7 years ago

I'd like to do this as part of a second push (to directly follow this one)

That sounds good to me. We definitely need to get better at pushing incremental changes rather than holding up a change to be absolutely perfect.

nataliafitzgerald commented 7 years ago

@ajbush @jordanafyne I double checked the hero content lengths by testing things out in Wagtail here: http://build.consumerfinance.gov/hero-content-test/.

Our grid changed recently (just a change to match our intended grid) so some of the counts were off because of that. I think what was happening with that 25 character count for the subheading after a two line heading was actually a typo. The 1 was missing at the beginning (125). Thanks for catching that!

Based on this experiment, I've made some tweaks:

Heading

Subheading

@jordanafyne - Could you take a look at this Wagtail mock-up next week and make sure the counts look correct? Do you know of a more fail safe, precise way to test this?

jordanafyne commented 7 years ago

@nataliafitzgerald I got very slightly different counts, which, as guidelines, I don't think matters very much, but if these numbers are going to be input into a Wagtail character counter plugin, then it may make a difference. Should probably set that hard limit at the lower number, if choosing between the two.

That Build demo is great -- I hope you're able to incorporate those images into the documentation.

Heading

One-line heading: 41 characters maximum Two-line heading: 83 characters maximum

Subheading

Subheading after one-line heading: Between 168 and 198 characters Subheading after two-line heading: Between 109 and 130 characters

nataliafitzgerald commented 7 years ago

@jordanafyne I figure when we (hopefully) build out the backend validation we can test out our counts to be sure our counts are right on the money. I'm ok with going with the lower numbers between yours and mine. The good news is that they look pretty close.

nataliafitzgerald commented 7 years ago

@Scotchester @kurzn Can you do one more full review of the hero page updates? Updated page layout: https://nataliafitzgerald.github.io/design-manual/global-elements/heroes.html

Also, @huetingj - Can we meet in the next couple of days to talk through the page?

nataliafitzgerald commented 7 years ago

@jimmynotjim @kurzn Also, as a part of this update, I'd like to suggest that we move the hero out of "Global patterns" and into "Page components."

I'll probably also open an issue so that we can start talking about the sections of the page, specifically "Global patterns" which seems to mostly contain page types and "Page components" which could be renamed "UI elements" or "UI components."

ielerol commented 7 years ago

We discussed this in a meeting, but I'm documenting here for the record that the original plan with the IA was that within global elements there would be a "page intros" subsection that contained heroes, text introductions and item introductions, since every page should have one of those.

Also, as a team we need to do some more explicit thinking around when a landing or sub-landing page should have a hero vs. a text introduction, which we ultimately want to document on this page. But that shouldn't hold up the work Natalia has already done.

jimmynotjim commented 7 years ago

I brought this up in chat, but is there a reason not to organize the DM by atomic type to keep the language consistent? That was the main reasons we decided to use Atomic Design to begin with, but it seems we're holding out within the DM itself.

nataliafitzgerald commented 7 years ago

I shared the hero page in my Platform team ("Remember the humans") meeting and got some valuable feedback. Thank you @ielerol!

I also met with @huetingj to go over the full page, doing a deeper dive into the "Style" section which is really graphic designer focused. She felt that this is a good step in the right direction. As she works through hero graphics as part of her project work we may learn more about what we'd like to think about stylistically and practically as we build photo heroes.

nataliafitzgerald commented 7 years ago

I shared this in my Design Working Session and received some additional feedback. Next, I'll map out what I'll tackle as part of this initial release and what I'll line up for the next release.

Here's the feedback I received:

@marteki @Dnpizarro @huetingj - Let me know if I missed anything.

nataliafitzgerald commented 7 years ago

Remaining tasks

This week's release

Next release

If anyone has anything to add that isn't captured in this list or reflected on the page, let me know or post below. I have pushed some additional updates live this evening: https://nataliafitzgerald.github.io/design-manual/global-elements/heroes.html

sarahsimpson09 commented 7 years ago

@nataliafitzgerald here is some Use Case language. Happy to tweak as needed! I'm also working on the updates to the 'no links in hero' language we talked about.

Use Case

WHEN TO USE  When orienting a user to a new section or topic.  The page operates mostly as a navigation tool with general information about a subject with links to lower-level pages with more specific information.

WHEN OTHER OPTIONS ARE BETTER  When introducing a specific piece of content, like a blog, press release, or other lengthy or detailed content.  When creating a lower-level page, like a learn or browse page.

nataliafitzgerald commented 7 years ago

Ok, I added your proposed updates @sarahsimpson09.

Here's the updated page: https://nataliafitzgerald.github.io/design-manual/global-elements/heroes.html

kurzn commented 7 years ago

Could be good to add examples of good headings/subheadings used in existing heroes as well. Something to consider down the line.

nataliafitzgerald commented 7 years ago

@kurzn Yes, I think that would be helpful for sure. I'll add it to the list of things we'd like to iron out/add next.

jimmynotjim commented 7 years ago

Should we add print rules for future work as well or should that go in it's own "we need to update everything for print" issue?

Scotchester commented 7 years ago

@jimmynotjim Did you mean to post that in a data viz issue? Or are you talking about how a hero prints if someone prints a page that has one?

jimmynotjim commented 7 years ago

The later