cfpb / design-manual

⚠️ THIS REPO IS DEPRECATED ⚠️ A set of design principles and standards for the Consumer Financial Protection Bureau.
https://cfpb.github.io/design-manual/
Creative Commons Zero v1.0 Universal
98 stars 71 forks source link

Add full bleed illustration option to hero graphic guidelines #462

Closed nataliafitzgerald closed 7 years ago

nataliafitzgerald commented 7 years ago

Add full bleed illustration option to hero graphic guidelines

User story Updates to hero graphic guidelines #461

Description

The full bleed illustration hero option has been available to users (and in use) for quite some time but the Design Manual does not include this option.

Full bleed illustrated hero: https://www.consumerfinance.gov/consumer-tools/prepaid-cards/

Task

Add full bleed illustration option to hero graphic guidelines

Ready Checklist

Acceptance criteria

Done Checklist

nataliafitzgerald commented 7 years ago

I've been working on this update as part of the overall hero page updates.

Here's the content related to bleed heroes:

Illustration (bleed)

Large screens (601+) hero_style_variations_bleed_large

Small screens (600-) hero_style_variations_bleed_small

jimmynotjim commented 7 years ago

@Scotchester Is 638px the tallest the hero is in height before breaking the image below the text? That seems wicked tall.

Scotchester commented 7 years ago

@jimmynotjim Correct. The 638 figure is a little annoying to calculate, but it's what the max height of the hero image should be on a 601px viewport, with the longest possible copy (i.e., tallest total hero space).

I won't spell it out further, because the current implementation has a width bug in it, which makes explaining the calculation cumbersome.

nataliafitzgerald commented 7 years ago

@jimmynotjim Yeah, here's the bullet that I included to try to explain it on the page: "Large screen image dimensions are based on maximum possible hero height at 601px width".

The maximum height was determined by using the maximum height that would be created at the 601px width - based on the content guidelines. Here's the image where I tried to figure it out in illustrator.

screen shot 2017-04-04 at 6 01 11 pm
jimmynotjim commented 7 years ago

@nataliafitzgerald ah sorry, I missed that bit. Thanks both of you for the clarification, it just seemed like an odd number.

nataliafitzgerald commented 7 years ago

Design Manual has been updated (updates have been merged). Closing issue.