cfpb / design-manual

⚠️ THIS REPO IS DEPRECATED ⚠️ A set of design principles and standards for the Consumer Financial Protection Bureau.
https://cfpb.github.io/design-manual/
Creative Commons Zero v1.0 Universal
98 stars 71 forks source link

Reduce bottom padding for wells #463

Closed nataliafitzgerald closed 6 years ago

nataliafitzgerald commented 7 years ago

Reduce bottom padding for wells

Description

The current bottom padding in wells is set to 60px. This creates a great deal of empty space and an imbalance within the well.

screen shot 2017-03-09 at 5 34 48 pm

Task

Reduce the bottom padding in wells to 30px. This will create balance within the well and on the page.

screen shot 2017-03-09 at 5 34 20 pm

Ready Checklist

Acceptance criteria

Done Checklist

nataliafitzgerald commented 7 years ago

@ajbush @huetingj @caheberer @marteki @Dnpizarro Looking for some discussion regarding this recommendation. Are you in support of this change? Please note that this is only one of a few recommendations I am making regarding the well. But, it's a small step in the right direction.

marteki commented 7 years ago

Yes, I'm in support of this change. It was confusing to see the 60px implementation on previous projects, and I feel like 30px is the right choice for bottom padding on all the instances I've come across to date.

jenn-franklin commented 7 years ago

I support this change. Particularly feels like too much space as it is now on small screens.

Scotchester commented 7 years ago

:+1:

ajbush commented 7 years ago

:+1:

caheberer commented 7 years ago

👍

nataliafitzgerald commented 6 years ago

@jimmynotjim @Scotchester It looks like there is general consensus about this update. How do we go about making it happen?

jimmynotjim commented 6 years ago

Moved to the Capital Framework issue tracker

jimmynotjim commented 6 years ago

Done in https://github.com/cfpb/capital-framework/pull/687