cfpb / design-manual

⚠️ THIS REPO IS DEPRECATED ⚠️ A set of design principles and standards for the Consumer Financial Protection Bureau.
https://cfpb.github.io/design-manual/
Creative Commons Zero v1.0 Universal
98 stars 71 forks source link

Update to CF v4 #466

Closed jimmynotjim closed 7 years ago

jimmynotjim commented 7 years ago

Updated the project to use the latest version of Capital Framework.

Additions

Removals

Changes

Testing

Review

Preview this PR without the whitespace changes

Screenshots

Notes

Todos

Checklist

Scotchester commented 7 years ago

This is not a problem with your PR, but looking at the expandables page, I realize that our :last-child { margin-bottom: 0; } rule has eliminated the bottom spacing in all expandables, which were counting on their last child's bottom margin to be there. I'll file an issue in capital-framework.

Scotchester commented 7 years ago

Got a couple issues on the Tables page:

screen shot 2017-03-23 at 15 50 02 screen shot 2017-03-23 at 15 50 22
jimmynotjim commented 7 years ago

Updated with @Scotchester fix for pagination and markup corrections for the tables. I removed the 100% inline widths because I'd like to solve that issue in cf-tables. I don't know if we should hold this up for that or not though.

jimmynotjim commented 7 years ago

It's going to get messy dealing with ongoing changes to the less files with this project on v3. Can we merge this?

Scotchester commented 7 years ago

Testing this again locally.

I removed the 100% inline widths because I'd like to solve that issue in cf-tables.

Are you proposing we set all table widths to 100% by default? I'm not sure we want to do that.

But anyway, a more efficient way to do it in this project would be to add a style for it in the project's stylesheets. I'll commit that, along with a fix for the pagination style to correctly show how it would look on a small screen.

We should also decide whether the expandable bottom padding issue should be a blocker to moving forward with this. As soon as we publish, those examples will look broken.

jimmynotjim commented 7 years ago

@Scotchester agreed that the best option would be setting them in the main stylesheet of this project. As far as the expandables, yes, we should fix that first. I can do that after I make the hero updates today.

Scotchester commented 7 years ago

Whoops, pushed that commit to my fork yesterday afternoon. Pushed it here now.

jimmynotjim commented 7 years ago

Expandables bug is being addressed at https://github.com/cfpb/AtomicComponent/pull/4 and https://github.com/cfpb/capital-framework/pull/471

jimmynotjim commented 7 years ago

@Scotchester I think I've addressed everything we discovered in this process. Hopefully we can merge this and keep moving on other improvements.

Scotchester commented 7 years ago

:+1: