Closed jimmynotjim closed 7 years ago
I would suggest that on the Minicons page, you don't have to follow the format of the section above it. Make the description a ⅔ column and the example a ⅓ column without the superfluous empty elements.
@Scotchester the problem with that is it throws off the grid
There isn't really a grid, though. None of the example visuals have a consistent grid.
I guess that's true. @caheberer what's your preference?
With the exception of the first intro paragraph, we only use 1/3 content blocks, so I'd prefer the earlier iteration.
Okedoke, @Scotchester want to change your review? I fixed the heading.
We currently don't document the animated icons despite them being a part of Capital Framework for some time.
Animating minicons has been available in Capital Framework for some time but never documented. This change adds that missing documentation.
Additions
Testing
npm update
to make sure you have the latest from Capital Frameworkgrunt build
, if you get an error rungrunt build -f
. There's a bug in the linting file.npm start
and navigate tohttp://localhost:4000/brand-guidelines/minicons.html#animation
Review
Preview this PR without the whitespace changes
Screenshots
Checklist