cfpb / design-manual

⚠️ THIS REPO IS DEPRECATED ⚠️ A set of design principles and standards for the Consumer Financial Protection Bureau.
https://cfpb.github.io/design-manual/
Creative Commons Zero v1.0 Universal
98 stars 71 forks source link

Add animated icons examples to the Design Manual documentation #490

Closed jimmynotjim closed 7 years ago

jimmynotjim commented 7 years ago

We currently don't document the animated icons despite them being a part of Capital Framework for some time.

Animating minicons has been available in Capital Framework for some time but never documented. This change adds that missing documentation.

Additions

Testing

Review

Preview this PR without the whitespace changes

Screenshots

screen shot 2017-04-27 at 5 26 00 pm

Checklist

Scotchester commented 7 years ago

I would suggest that on the Minicons page, you don't have to follow the format of the section above it. Make the description a ⅔ column and the example a ⅓ column without the superfluous empty elements.

jimmynotjim commented 7 years ago

@Scotchester the problem with that is it throws off the grid

screen shot 2017-04-28 at 12 44 56 pm

Scotchester commented 7 years ago

There isn't really a grid, though. None of the example visuals have a consistent grid.

jimmynotjim commented 7 years ago

I guess that's true. @caheberer what's your preference?

caheberer commented 7 years ago

With the exception of the first intro paragraph, we only use 1/3 content blocks, so I'd prefer the earlier iteration.

jimmynotjim commented 7 years ago

Okedoke, @Scotchester want to change your review? I fixed the heading.